chore(build): correct why whatsapp-web.js stays out of the sidecar bundle (P1.7)
The sidecar already bundles the AWS S3 client through other code, so it is not a reason to keep whatsapp-web.js external. The TypeScript compiler, pulled in by Puppeteer's config loader, is.
This commit is contained in:
@@ -134,8 +134,8 @@ const EXTERNAL = [
|
||||
'chromium-bidi/*',
|
||||
// WhatsApp channel (ADR-0005). whatsapp-web.js is CommonJS that relies on
|
||||
// __dirname and fails inside the ESM bundle; bundling it would also inline
|
||||
// its LGPL-3.0 dependency node-webpmux and unused optional code (TypeScript,
|
||||
// the AWS S3 client). Staged as separate packages instead.
|
||||
// its LGPL-3.0 dependency node-webpmux and the TypeScript compiler (an
|
||||
// optional peer of Puppeteer's config loader). Staged as separate packages.
|
||||
'whatsapp-web.js',
|
||||
'@puppeteer/browsers',
|
||||
];
|
||||
|
||||
Reference in New Issue
Block a user