From 10e67f37a50612ff9e2222239f0b60134006789c Mon Sep 17 00:00:00 2001 From: "shumeiko.it" Date: Sat, 24 Oct 2026 11:52:34 +0200 Subject: [PATCH] chore(build): correct why whatsapp-web.js stays out of the sidecar bundle (P1.7) The sidecar already bundles the AWS S3 client through other code, so it is not a reason to keep whatsapp-web.js external. The TypeScript compiler, pulled in by Puppeteer's config loader, is. --- scripts/build-sidecar.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/build-sidecar.mjs b/scripts/build-sidecar.mjs index a42c105..739c7a7 100644 --- a/scripts/build-sidecar.mjs +++ b/scripts/build-sidecar.mjs @@ -134,8 +134,8 @@ const EXTERNAL = [ 'chromium-bidi/*', // WhatsApp channel (ADR-0005). whatsapp-web.js is CommonJS that relies on // __dirname and fails inside the ESM bundle; bundling it would also inline - // its LGPL-3.0 dependency node-webpmux and unused optional code (TypeScript, - // the AWS S3 client). Staged as separate packages instead. + // its LGPL-3.0 dependency node-webpmux and the TypeScript compiler (an + // optional peer of Puppeteer's config loader). Staged as separate packages. 'whatsapp-web.js', '@puppeteer/browsers', ];