Files
waggle-os/packages/server/tests/local/provider-env.test.ts
shumeiko.it 2226ec1bd7 refactor(server): move the config.json provider-key copy out of VaultStore (P1.2)
VaultStore.migrateFromConfig had two callers, both in the server. It is now
copyProviderKeysToVault in provider-env.ts, next to
migrateLegacyProviderKeysToVault, with the same rules: copy keys that have a
value, keep keys the vault already holds, store models and baseUrl as metadata.
Its tests moved from core to provider-env.test.ts.
2026-10-24 17:35:36 +02:00

114 lines
4.1 KiB
TypeScript

import fs from 'node:fs';
import os from 'node:os';
import path from 'node:path';
import { afterEach, describe, expect, it } from 'vitest';
import { VaultStore } from '@waggle/core';
import {
applyProviderKeyToEnv,
copyProviderKeysToVault,
hydrateProviderEnvFromVault,
migrateLegacyProviderKeysToVault,
} from '../../src/local/provider-env.js';
const originalEnv = new Map<string, string | undefined>();
function rememberEnv(name: string): void {
if (!originalEnv.has(name)) originalEnv.set(name, process.env[name]);
}
afterEach(() => {
for (const [name, value] of originalEnv) {
if (value === undefined) delete process.env[name];
else process.env[name] = value;
}
originalEnv.clear();
});
describe('provider environment hydration', () => {
it('maps provider keys to every environment name required by the router', () => {
rememberEnv('GEMINI_API_KEY');
rememberEnv('GOOGLE_API_KEY');
delete process.env.GEMINI_API_KEY;
delete process.env.GOOGLE_API_KEY;
expect(applyProviderKeyToEnv('google', 'google-secret')).toBe(2);
expect(process.env.GEMINI_API_KEY).toBe('google-secret');
expect(process.env.GOOGLE_API_KEY).toBe('google-secret');
});
it('hydrates vault keys without replacing an explicit process override', () => {
const dataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'waggle-provider-env-'));
rememberEnv('OPENAI_API_KEY');
process.env.OPENAI_API_KEY = 'explicit-key';
try {
const vault = new VaultStore(dataDir);
vault.set('openai', 'vault-key');
expect(hydrateProviderEnvFromVault(vault)).toBe(0);
expect(process.env.OPENAI_API_KEY).toBe('explicit-key');
} finally {
fs.rmSync(dataDir, { recursive: true, force: true });
}
});
it('copies config.json provider keys into the vault with their models and base URL', () => {
const dataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'waggle-provider-copy-'));
try {
const vault = new VaultStore(dataDir);
expect(copyProviderKeysToVault(vault, {
anthropic: { apiKey: 'sk-ant-key-1', models: ['claude-sonnet-4-6'], baseUrl: undefined },
openai: { apiKey: 'sk-openai-key-1', models: ['gpt-4o'], baseUrl: 'https://api.openai.com' },
empty: { apiKey: '', models: [] },
})).toBe(2);
expect(vault.get('anthropic')).toMatchObject({
value: 'sk-ant-key-1',
metadata: { models: ['claude-sonnet-4-6'] },
});
expect(vault.get('openai')).toMatchObject({
value: 'sk-openai-key-1',
metadata: { models: ['gpt-4o'], baseUrl: 'https://api.openai.com' },
});
expect(vault.has('empty')).toBe(false);
} finally {
fs.rmSync(dataDir, { recursive: true, force: true });
}
});
it('keeps a key the vault already holds', () => {
const dataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'waggle-provider-copy-'));
try {
const vault = new VaultStore(dataDir);
vault.set('anthropic', 'sk-ant-from-settings');
const providers = { anthropic: { apiKey: 'sk-ant-from-config', models: ['claude-sonnet-4-6'] } };
expect(copyProviderKeysToVault(vault, providers)).toBe(0);
expect(vault.get('anthropic')?.value).toBe('sk-ant-from-settings');
} finally {
fs.rmSync(dataDir, { recursive: true, force: true });
}
});
it('migrates and scrubs legacy keys before startup catalog discovery', () => {
const dataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'waggle-provider-migrate-'));
const configPath = path.join(dataDir, 'config.json');
fs.writeFileSync(configPath, JSON.stringify({
providers: {
openai: { apiKey: 'legacy-secret', models: ['old-static-entry'] },
},
}));
try {
const vault = new VaultStore(dataDir);
expect(migrateLegacyProviderKeysToVault(dataDir, vault)).toBe(1);
expect(vault.get('openai')?.value).toBe('legacy-secret');
expect(JSON.parse(fs.readFileSync(configPath, 'utf8')).providers.openai).toEqual({
apiKey: '',
models: ['old-static-entry'],
});
} finally {
fs.rmSync(dataDir, { recursive: true, force: true });
}
});
});