Files
Oleg Maslov 0c3e2ead3b
Some checks failed
Installer Smoke / installer-smoke (push) Has been cancelled
moving
2026-09-02 10:10:29 +02:00

4.5 KiB
Raw Permalink Blame History

Warm-Hive PR6a — Build + Review + Live Smoke (2026-06-18)

Verdict: PASS. PR6a (Benchmarks 17 + Platform 18 + NotFound reskin) is built, reviewed, and live-verified against a real sidecar. All gates green. Review found 0 HIGH, 2 MEDIUM (both fixed + re-verified), 0 LOW. 0 PR6a-attributable console errors. Ready for merge into the PR6 line.

Scope (PR6 sub-PR a — first of the 3-way split)

Two net-new, pure-UI, static-data, ⌘K-only surfaces + the 404 reskin. No backend. Branch feature/warm-hive-pr6.

  • 17 Benchmarks — capabilities matrix (11 rows × 6 cols) + Memory SOTA (LoCoMo bars). BenchmarkApp.tsx (+test).
  • 18 Platform — Desktop / Boot (static showcase) / Coming-next tabs. PlatformApp.tsx (+test).
  • 404pages/NotFound.tsx reskin (D5; standalone route, not a Platform tab).
  • Wiring (integrator-owned): routes/{BenchmarkRoute,PlatformRoute}.tsx + barrel, App.tsx (2 routes), command-catalog.ts (2 Power-tools ⌘K entries).

Build method

2 parallel build agents on disjoint files (Benchmark vs Platform/NotFound) → main-agent wiring of the shared files (no parallel-write conflicts). Decisions D3/D5/D6/D21 applied.

Gates (re-run after the MEDIUM fixes)

Gate Result
tsc -p apps/web/tsconfig.app.json 0 errors
FE vitest (BenchmarkApp · PlatformApp · p7-b3-command-center) 11/11 (3 files)
eslint (PR6a changed files) 0 errors

Adversarial review (4 dimensions, workflow wf_2ce6b417)

  • Design-fidelity + no-fabrication (Benchmark): PASS — all 11 matrix rows + 66 marks match benchmark.html exactly; LoCoMo bars 87.66/81.95/78.05/62.47 + stats (+5.71, p<10⁻⁵, 92.75%, 100% 5883ms) verbatim; competitors honestly credited ● on deep terminal coding; "positioning view, not a lab benchmark" disclaimer + dated provenance present. No invented/rounded numbers.
  • Correctness / a11y / routing: PASS — wrappers above catch-all; unique ⌘K ids + real routes + valid icons; tablists use role/aria-selected; no runtime/console hazards.
  • Warm-token (D21): PASS — only warm semantic vars; the sole raw hex (#1a1407 on-honey text, macOS traffic-light dots) are allowed OS-chrome exceptions per the design.
  • Design-fidelity (Platform): 2 MEDIUM → fixed:
    1. Channel icon tints were hardcoded honey-wash → now per-channel per platform.html:160-175 (Desktop honey · Browser work-wash · Messaging honey · Mobile intel-wash). Live-verified computed bg: honey rgba(233,165,44,.1) / work rgba(122,166,214,.12) / intel rgba(177,150,221,.12).
    2. Boot hex used Tailwind animate-pulse (opacity) + static shadow → now a boot-hex-pulse keyframe (added to index.css, matching the repo's keyframe convention) animating the box-shadow per platform.html:57-58, with a prefers-reduced-motion fallback. Live-verified animationName: boot-hex-pulse, 2.2s.

Live smoke (real sidecar :3333, Vite :8080)

  • /benchmarks — Capabilities matrix (11 rows, ●/◐/○, honey Waggle column, honest terminal-coding row, disclaimer) + Memory SOTA (4 bars + 3 stat chips + caveat + OSS link). Toggle works. 0 console errors. (01, 06)
  • /platform — 3 tabs: Desktop (macOS↔Windows toggle + spec tiles), Boot (static showcase, pulsing hex), Coming-next (4 channel cards, per-channel tints). 0 console errors. (02, 03, 05)
  • 404/this-cell-is-empty → reskinned "This cell of the hive is empty." + back-to-Home + ⌘K hint. The one console.error is the intentional 404 telemetry log (pre-existing NotFound behavior), fires only on a real bad route. (04)
  • ⌘K discovery — typing "benchmark" surfaces the live "Benchmarks — capabilities · memory SOTA" entry (DOM-confirmed; cmdk items aren't exposed in the a11y tree).

Decisions honored

D3 (inline static benchmark data, dated 2026-06-18, verbatim, no fabrication) · D5 (404 = standalone NotFound route, not a Platform tab) · D6 (Boot = static showcase, not wired to real AppShell boot) · D21 (warm tokens; OS-chrome hex exempt).

Screenshots

01 benchmark SOTA · 02 platform desktop · 03 platform coming-next (per-channel tints) · 04 404 reskin · 05 platform boot (pulse) · 06 benchmark capabilities matrix. (Committed: 0205 small; 01/06 are large full-page captures kept local.)

Open / follow-ups (none block merge)

  • None for PR6a. Next in the PR6 line: PR6b (reskin + feature-fill of 06·07·08·12·16) then PR6c (04·15).