fix(memory): erase forgotten memories from mem0's history database
mem0's delete kept the deleted text in memory_history, and fact extraction keeps the last messages of each scope in the same file. forget now purges the memory's history rows, and forgetting a whole scope also drops the conversation messages mem0 kept for it.
This commit is contained in:
@@ -4,7 +4,8 @@ import type { AddressInfo } from 'node:net';
|
||||
import os from 'node:os';
|
||||
import path from 'node:path';
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest';
|
||||
import { PERSONAL_SCOPE } from '@waggle/memory-contract';
|
||||
import { PERSONAL_SCOPE, workspaceScope } from '@waggle/memory-contract';
|
||||
import Database from 'better-sqlite3';
|
||||
import { createMem0MemoryStore, createWordEmbedder, EmbedderMismatchError, type TextEmbedder } from '../src/index.js';
|
||||
import { describeMemoryStoreContract } from '../../memory-contract/tests/contract-suite.js';
|
||||
|
||||
@@ -164,6 +165,58 @@ describe('mem0 store — local behaviour', () => {
|
||||
}
|
||||
});
|
||||
|
||||
it('erases the text of a forgotten memory from the history database', async () => {
|
||||
const directory = tempDir();
|
||||
const store = await createMem0MemoryStore({ directory, embedder: wordEmbedder });
|
||||
const [change] = await store.remember({ scope: PERSONAL_SCOPE, text: 'My passport number is X1234' });
|
||||
await store.update(change!.record.id, { text: 'My passport number is Y5678' });
|
||||
expect(await store.forget(change!.record.id)).toBe(true);
|
||||
expect(await store.history(change!.record.id)).toEqual([]);
|
||||
const db = new Database(path.join(directory, 'history.db'), { readonly: true });
|
||||
const leftovers = db.prepare("SELECT COUNT(*) AS n FROM memory_history WHERE coalesce(previous_value, '') || coalesce(new_value, '') LIKE '%passport%'").get() as { n: number };
|
||||
db.close();
|
||||
expect(leftovers.n).toBe(0);
|
||||
await store.close();
|
||||
});
|
||||
|
||||
it('erases the conversation mem0 kept for a scope when the whole scope is forgotten', async () => {
|
||||
const server = http.createServer((req, res) => {
|
||||
req.resume();
|
||||
req.on('end', () => {
|
||||
res.setHeader('Content-Type', 'application/json');
|
||||
res.end(JSON.stringify({
|
||||
id: 'chatcmpl-test', object: 'chat.completion', created: 0, model: 'm',
|
||||
choices: [{ index: 0, finish_reason: 'stop', message: { role: 'assistant', content: '{"memory":[]}' } }],
|
||||
usage: { prompt_tokens: 1, completion_tokens: 1, total_tokens: 2 },
|
||||
}));
|
||||
});
|
||||
});
|
||||
await new Promise<void>((resolve) => server.listen(0, '127.0.0.1', resolve));
|
||||
const { port } = server.address() as AddressInfo;
|
||||
try {
|
||||
const directory = tempDir();
|
||||
const store = await createMem0MemoryStore({
|
||||
directory,
|
||||
embedder: wordEmbedder,
|
||||
extractionModel: { baseURL: `http://127.0.0.1:${port}/v1`, apiKey: 'k', model: 'm' },
|
||||
});
|
||||
const scope = workspaceScope('ws&1');
|
||||
await store.remember({ scope, conversation: [{ role: 'user', content: 'Our launch is in May.' }] });
|
||||
const count = () => {
|
||||
const db = new Database(path.join(directory, 'history.db'), { readonly: true });
|
||||
const row = db.prepare('SELECT COUNT(*) AS n FROM messages').get() as { n: number };
|
||||
db.close();
|
||||
return row.n;
|
||||
};
|
||||
expect(count()).toBeGreaterThan(0);
|
||||
await store.forgetMatching({ scopes: [scope] });
|
||||
expect(count()).toBe(0);
|
||||
await store.close();
|
||||
} finally {
|
||||
await new Promise<void>((resolve) => server.close(() => resolve()));
|
||||
}
|
||||
});
|
||||
|
||||
it('refuses to open a store with a different embedder', async () => {
|
||||
const directory = tempDir();
|
||||
const first = await createMem0MemoryStore({ directory, embedder: { ...wordEmbedder, id: 'model-a' } });
|
||||
|
||||
Reference in New Issue
Block a user