diff --git a/package-lock.json b/package-lock.json index 473e4ca..b5f9b08 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25182,6 +25182,10 @@ "dependencies": { "@waggle/memory-contract": "*", "mem0ai": "3.3.1" + }, + "devDependencies": { + "@types/better-sqlite3": "^7.6.13", + "better-sqlite3": "^12.6.2" } }, "packages/memory-mem0/node_modules/@anthropic-ai/sdk": { diff --git a/packages/memory-mem0/package.json b/packages/memory-mem0/package.json index 2acc249..1ce19cf 100644 --- a/packages/memory-mem0/package.json +++ b/packages/memory-mem0/package.json @@ -19,5 +19,9 @@ "dependencies": { "@waggle/memory-contract": "*", "mem0ai": "3.3.1" + }, + "devDependencies": { + "@types/better-sqlite3": "^7.6.13", + "better-sqlite3": "^12.6.2" } } diff --git a/packages/memory-mem0/src/index.ts b/packages/memory-mem0/src/index.ts index 99c8f71..c488f2b 100644 --- a/packages/memory-mem0/src/index.ts +++ b/packages/memory-mem0/src/index.ts @@ -148,6 +148,14 @@ export async function createMem0MemoryStore(options: Mem0MemoryStoreOptions): Pr knowledgeGraph: false, }; + // Erasing a memory must erase its text. mem0's delete keeps the old text in + // its history table, and extraction keeps the last messages of each scope; + // both live in history.db, which mem0 3.3.1 holds open as `db.db`. + const historyDb = (mem0 as unknown as { db?: { db?: HistoryDatabase } }).db?.db; + if (!historyDb) throw new Error('mem0 changed its internals: no history database to purge'); + const purgeHistory = historyDb.prepare('DELETE FROM memory_history WHERE memory_id = ?'); + const purgeMessages = historyDb.prepare('DELETE FROM messages WHERE session_scope = ?'); + let closed = false; const ensureOpen = (): void => { if (closed) throw new Error('memory store is closed'); @@ -269,13 +277,20 @@ export async function createMem0MemoryStore(options: Mem0MemoryStoreOptions): Pr ensureOpen(); if (!(await getRecord(id))) return false; await mem0.delete(id); + purgeHistory.run(id); return true; }, async forgetMatching(filter: MemoryFilter): Promise { ensureOpen(); const doomed = await matching(filter); - for (const record of doomed) await mem0.delete(record.id); + for (const record of doomed) { + await mem0.delete(record.id); + purgeHistory.run(record.id); + } + if (isWholeScope(filter)) { + for (const scope of filter.scopes) purgeMessages.run(sessionScope(scope)); + } return doomed.length; }, @@ -316,6 +331,24 @@ function toHistoryEntry(row: HistoryRow): MemoryHistoryEntry | null { return { event, previousText: row.previous_value ?? null, text: row.new_value ?? null, at }; } +/** The part of better-sqlite3 the store uses on mem0's history database. */ +interface HistoryDatabase { + prepare(sql: string): { run(...params: unknown[]): unknown }; +} + +/** A filter that selects everything in its scopes. */ +function isWholeScope(filter: MemoryFilter): boolean { + return !filter.kinds && !filter.minImportance && filter.origin === undefined + && filter.sessionId === undefined && filter.since === undefined && filter.until === undefined; +} + +/** mem0's key for the conversation messages it keeps per scope (agent_id, user_id, sorted). */ +function sessionScope(scope: MemoryScope): string { + const escape = (value: string): string => + value.replace(/%/g, '%25').replace(/&/g, '%26').replace(/=/g, '%3D'); + return `agent_id=${escape(scopeKey(scope))}&user_id=${escape(USER_ID)}`; +} + function scopeFilter(scope: MemoryScope): { user_id: string; agent_id: string } { return { user_id: USER_ID, agent_id: scopeKey(scope) }; } diff --git a/packages/memory-mem0/tests/mem0-store.test.ts b/packages/memory-mem0/tests/mem0-store.test.ts index 1c17d14..4ce2fcb 100644 --- a/packages/memory-mem0/tests/mem0-store.test.ts +++ b/packages/memory-mem0/tests/mem0-store.test.ts @@ -4,7 +4,8 @@ import type { AddressInfo } from 'node:net'; import os from 'node:os'; import path from 'node:path'; import { afterEach, describe, expect, it, vi } from 'vitest'; -import { PERSONAL_SCOPE } from '@waggle/memory-contract'; +import { PERSONAL_SCOPE, workspaceScope } from '@waggle/memory-contract'; +import Database from 'better-sqlite3'; import { createMem0MemoryStore, createWordEmbedder, EmbedderMismatchError, type TextEmbedder } from '../src/index.js'; import { describeMemoryStoreContract } from '../../memory-contract/tests/contract-suite.js'; @@ -164,6 +165,58 @@ describe('mem0 store — local behaviour', () => { } }); + it('erases the text of a forgotten memory from the history database', async () => { + const directory = tempDir(); + const store = await createMem0MemoryStore({ directory, embedder: wordEmbedder }); + const [change] = await store.remember({ scope: PERSONAL_SCOPE, text: 'My passport number is X1234' }); + await store.update(change!.record.id, { text: 'My passport number is Y5678' }); + expect(await store.forget(change!.record.id)).toBe(true); + expect(await store.history(change!.record.id)).toEqual([]); + const db = new Database(path.join(directory, 'history.db'), { readonly: true }); + const leftovers = db.prepare("SELECT COUNT(*) AS n FROM memory_history WHERE coalesce(previous_value, '') || coalesce(new_value, '') LIKE '%passport%'").get() as { n: number }; + db.close(); + expect(leftovers.n).toBe(0); + await store.close(); + }); + + it('erases the conversation mem0 kept for a scope when the whole scope is forgotten', async () => { + const server = http.createServer((req, res) => { + req.resume(); + req.on('end', () => { + res.setHeader('Content-Type', 'application/json'); + res.end(JSON.stringify({ + id: 'chatcmpl-test', object: 'chat.completion', created: 0, model: 'm', + choices: [{ index: 0, finish_reason: 'stop', message: { role: 'assistant', content: '{"memory":[]}' } }], + usage: { prompt_tokens: 1, completion_tokens: 1, total_tokens: 2 }, + })); + }); + }); + await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve)); + const { port } = server.address() as AddressInfo; + try { + const directory = tempDir(); + const store = await createMem0MemoryStore({ + directory, + embedder: wordEmbedder, + extractionModel: { baseURL: `http://127.0.0.1:${port}/v1`, apiKey: 'k', model: 'm' }, + }); + const scope = workspaceScope('ws&1'); + await store.remember({ scope, conversation: [{ role: 'user', content: 'Our launch is in May.' }] }); + const count = () => { + const db = new Database(path.join(directory, 'history.db'), { readonly: true }); + const row = db.prepare('SELECT COUNT(*) AS n FROM messages').get() as { n: number }; + db.close(); + return row.n; + }; + expect(count()).toBeGreaterThan(0); + await store.forgetMatching({ scopes: [scope] }); + expect(count()).toBe(0); + await store.close(); + } finally { + await new Promise((resolve) => server.close(() => resolve())); + } + }); + it('refuses to open a store with a different embedder', async () => { const directory = tempDir(); const first = await createMem0MemoryStore({ directory, embedder: { ...wordEmbedder, id: 'model-a' } });