Files
waggle-os/packages/server/tests/local/feedback-routes.test.ts
shumeiko.it 2e1999a3f6 refactor: remove self-learning and the optimizer package (P1.4)
Self-learning is excluded from the community edition (ADR-0004); the
project owner reworks it separately. Cost tracking stays.

- agent: delete behaviour evolution (evolve-schema, iterative GEPA,
  compose-evolution, evolution gates, orchestrator and deploy),
  improvement and correction detection, AgentLearning, the eval-dataset
  builder, optimization-capture and the agent_insights tool. Secret
  detection moves from eval-dataset to secret-patterns. The LLM wiring
  keeps only the Haiku adapter and judge call used by skill audit and
  hygiene, so @ax-llm/ax is now declared by agent instead of server.
- server: delete /api/evolution/*, the evolution and optimizer services,
  GEPA expansion of the first chat message, the prompt_optimization and
  monthly_assessment jobs, the idle-session reviewer and its
  session-reviewer persona, prompt injection of past corrections and
  thumbs-down recorded as correction signals. Existing job rows of the
  removed types are ignored, not deleted.
- core: delete OptimizationLogStore; stop re-exporting the improvement
  signal and evolution run stores.
- web: delete the Evolution screen and the two job types in the
  automation editor.
- delete packages/optimizer.

Also logs UF-027 (self-learning loops read data nothing collects) and
UF-028 (the Settings prompt-shape choice is ignored by chat).
2026-10-20 00:54:58 +02:00

205 lines
5.9 KiB
TypeScript

/**
* Feedback REST API Route Tests
*
* Tests the two feedback endpoints:
* POST /api/feedback — record user feedback
* GET /api/feedback/stats — get feedback stats
*/
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import path from 'node:path';
import fs from 'node:fs';
import os from 'node:os';
import Fastify from 'fastify';
import { MindDB } from '@waggle/core';
import { feedbackRoutes } from '../../src/local/routes/feedback.js';
/** Minimal multiMind mock that provides a real MindDB for the personal mind. */
function createTestServer(db: MindDB) {
const server = Fastify({ logger: false });
server.decorate('multiMind', {
personal: db,
});
server.register(feedbackRoutes);
return { server };
}
describe('Feedback Routes', () => {
let db: MindDB;
let server: ReturnType<typeof Fastify>;
beforeEach(() => {
db = new MindDB(':memory:');
const result = createTestServer(db);
server = result.server;
});
afterEach(async () => {
await server.close();
db.close();
});
// ── POST /api/feedback ──────────────────────────────────────────────
describe('POST /api/feedback', () => {
it('stores thumbs-up feedback', async () => {
const res = await server.inject({
method: 'POST',
url: '/api/feedback',
payload: {
sessionId: 'sess-1',
messageIndex: 3,
rating: 'up',
},
});
expect(res.statusCode).toBe(200);
expect(res.json()).toEqual({ ok: true });
});
it('stores thumbs-down feedback with reason', async () => {
const res = await server.inject({
method: 'POST',
url: '/api/feedback',
payload: {
sessionId: 'sess-1',
messageIndex: 5,
rating: 'down',
reason: 'too_verbose',
detail: 'The response was way too long',
},
});
expect(res.statusCode).toBe(200);
expect(res.json()).toEqual({ ok: true });
});
it('rejects missing sessionId', async () => {
const res = await server.inject({
method: 'POST',
url: '/api/feedback',
payload: {
messageIndex: 3,
rating: 'up',
},
});
expect(res.statusCode).toBe(400);
expect(res.json().error).toContain('sessionId');
});
it('rejects invalid rating', async () => {
const res = await server.inject({
method: 'POST',
url: '/api/feedback',
payload: {
sessionId: 'sess-1',
messageIndex: 3,
rating: 'meh',
},
});
expect(res.statusCode).toBe(400);
expect(res.json().error).toContain('rating');
});
it('rejects invalid reason', async () => {
const res = await server.inject({
method: 'POST',
url: '/api/feedback',
payload: {
sessionId: 'sess-1',
messageIndex: 3,
rating: 'down',
reason: 'invalid_reason',
},
});
expect(res.statusCode).toBe(400);
expect(res.json().error).toContain('reason');
});
it('rejects negative messageIndex', async () => {
const res = await server.inject({
method: 'POST',
url: '/api/feedback',
payload: {
sessionId: 'sess-1',
messageIndex: -1,
rating: 'up',
},
});
expect(res.statusCode).toBe(400);
expect(res.json().error).toContain('messageIndex');
});
});
// ── GET /api/feedback/stats ─────────────────────────────────────────
describe('GET /api/feedback/stats', () => {
it('returns empty stats initially', async () => {
const res = await server.inject({
method: 'GET',
url: '/api/feedback/stats',
});
expect(res.statusCode).toBe(200);
const body = res.json();
expect(body.totalFeedback).toBe(0);
expect(body.positiveRate).toBe(0);
expect(body.topIssues).toEqual([]);
expect(typeof body.improvementTrend).toBe('string');
});
it('returns correct stats shape after feedback', async () => {
// Submit some feedback
await server.inject({
method: 'POST',
url: '/api/feedback',
payload: { sessionId: 's1', messageIndex: 0, rating: 'up' },
});
await server.inject({
method: 'POST',
url: '/api/feedback',
payload: { sessionId: 's1', messageIndex: 1, rating: 'up' },
});
await server.inject({
method: 'POST',
url: '/api/feedback',
payload: { sessionId: 's1', messageIndex: 2, rating: 'down', reason: 'too_verbose' },
});
const res = await server.inject({
method: 'GET',
url: '/api/feedback/stats',
});
expect(res.statusCode).toBe(200);
const body = res.json();
expect(body.totalFeedback).toBe(3);
expect(body.positiveRate).toBeCloseTo(0.67, 1);
expect(body.topIssues).toContain('too_verbose');
expect(typeof body.improvementTrend).toBe('string');
});
it('tracks top issues from negative feedback', async () => {
// Submit multiple negative feedbacks with different reasons
for (let i = 0; i < 3; i++) {
await server.inject({
method: 'POST',
url: '/api/feedback',
payload: { sessionId: 's1', messageIndex: i, rating: 'down', reason: 'wrong_answer' },
});
}
await server.inject({
method: 'POST',
url: '/api/feedback',
payload: { sessionId: 's1', messageIndex: 10, rating: 'down', reason: 'too_slow' },
});
const res = await server.inject({
method: 'GET',
url: '/api/feedback/stats',
});
const body = res.json();
expect(body.topIssues[0]).toBe('wrong_answer'); // Most common
expect(body.topIssues).toContain('too_slow');
});
});
});