Files
waggle-os/packages/agent/tests/save-memory-conflict.test.ts
shumeiko.it ac23bbd7a6 test(agent): move the agent suites onto the memory contract (P1.5)
Rewrites the orchestrator, recall, compaction, save_memory and assembler
suites for MemoryStore (createInMemoryMemoryStore; mem0 with the word
embedder for the M3b integration test), string ids, async prompt building
and setWorkspace(). Creation times are set with fake timers, since a write
cannot set its own. Stores of Waggle's own data (identity, traces) are built
on WaggleDB; the session-manager stubs use the new create() signature.

Kept behaviour: importance lane (cap, active scope, temporary exclusion),
profile and event lanes, date window and its fallback, catch-up, injection
blocking of recall and preloaded context, autosave safety, decision consent,
compaction update-in-place, reranker wiring.

New tests: recall with a workspace active versus personal only;
fetchRecentMemories ordering; toRecallFrame; context loader; save_memory
routing, dedup, rate limit, dramatic-claim downgrade and contradiction
scope; search_memory and search_all_workspaces; pattern write-back kinds,
scopes and sign gate; read_other_workspace; reranker off unless
WAGGLE_RERANKER=1, wider rerank pool, failure fallbacks.

Deleted, because the behaviour is gone:
- w46-rawdetail-recall.test.ts: the raw-turn (RAWDETAIL) recall lane.
- orchestrator.test.ts, query_knowledge (3 tests) and the recall-hardening
  M4 "Key Knowledge" test: the knowledge graph is not in v1 (ADR-0002).
- orchestrator-context-frames "profile override": scoring profiles.
- Assertions on I/P frame types, GOP sessions, FTS rows, the "Memory Facts"
  lane, cognify stages and session/entity counts were replaced by the
  equivalent contract-level checks.
2026-10-24 13:19:06 +02:00

86 lines
3.1 KiB
TypeScript

/**
* Skills 2.0 gap K — write-path conflict detection.
*
* When save_memory writes a new memory that contradicts an existing one
* (detectContradiction), the save still succeeds but the return string
* carries a [flag: contradicts_existing …] marker.
*/
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import { WaggleDB, IdentityLayer, AwarenessLayer } from '@waggle/core';
import { createInMemoryMemoryStore, PERSONAL_SCOPE, type MemoryStore } from '@waggle/memory-contract';
import { createMindTools } from '../src/tools.js';
import type { ToolDefinition } from '../src/tools.js';
describe('save_memory — gap K (write-path conflict detection)', () => {
let waggleDb: WaggleDB;
let memory: MemoryStore;
let tools: ToolDefinition[];
function getSaveMemory(): ToolDefinition {
const tool = tools.find(t => t.name === 'save_memory');
if (!tool) throw new Error('save_memory tool not found');
return tool;
}
beforeEach(() => {
waggleDb = new WaggleDB(':memory:');
memory = createInMemoryMemoryStore();
tools = createMindTools({
memory,
identity: new IdentityLayer(waggleDb),
awareness: new AwarenessLayer(waggleDb),
});
});
afterEach(() => {
waggleDb.close();
});
it('flags contradictions and still saves the memory', async () => {
const save = getSaveMemory();
// Prime with an affirmative decision.
// Using "enable/disable feature flag rollout users" — the existing
// detectContradiction algorithm needs asymmetric sentiment to fire;
// inputs with "will" in both sides add positive noise that can mask
// the polarity swing. Keep inputs tight and unambiguous.
const first = await save.execute({
content: 'Decision: enable feature flag rollout for users; proceed and confirmed.',
importance: 'important',
target: 'personal',
source: 'user_stated',
});
expect(first).toContain('Memory saved');
expect(first).not.toContain('contradicts_existing');
// Contradicting decision — disable/reject/cancel instead of enable/approve
const second = await save.execute({
content: 'Decision: disable feature flag rollout for users; cancel and reject.',
importance: 'important',
target: 'personal',
source: 'user_stated',
});
// Save still succeeded — conflict is a flag, not an abort
expect(second).toContain('Memory saved');
// But the return message is annotated
expect(second).toContain('[flag: contradicts_existing');
expect(await memory.count({ scopes: [PERSONAL_SCOPE] })).toBe(2);
});
it('non-contradicting saves are not flagged', async () => {
const save = getSaveMemory();
await save.execute({
content: 'Decision: we chose PostgreSQL for analytics; approved and confirmed.',
target: 'personal',
source: 'user_stated',
});
const result = await save.execute({
content: 'Meeting notes from standup — discussed roadmap for Q2 and sprint planning.',
target: 'personal',
source: 'user_stated',
});
expect(result).not.toContain('contradicts_existing');
});
});