fix(deps): move exceljs to unzipper 0.12.3 to drop the unlicensed buffers (UF-060)
exceljs 4.4.0 pulled unzipper 0.10, which depends on binary and through it on buffers 0.1.1, a package with no license grant. An npm override moves exceljs to unzipper 0.12.3, the version whatsapp-web.js already uses, so binary, buffers, chainsaw and traverse leave the installers. Waggle only writes workbooks and loads them through JSZip; both still work. The license gate drops the two exceptions it no longer needs.
This commit is contained in:
@@ -88,7 +88,7 @@ Baseline: commit `b20b138` of the main Waggle repository.
|
||||
| UF-057 | At phone width the sidebar rail takes a fifth of the screen | Fixed | Web UI |
|
||||
| UF-058 | The mock-embedding warning names a variable Waggle does not read | Fixed | Sidecar, embeddings |
|
||||
| UF-059 | Installers ship third-party code without its notices | Open | Licensing, packaging |
|
||||
| UF-060 | The sidecar ships `buffers` 0.1.1, which has no license | Open | Licensing |
|
||||
| UF-060 | The sidecar ships `buffers` 0.1.1, which has no license | Fixed | Licensing |
|
||||
| UF-061 | Key messages send users to "Settings > API Keys", which does not exist | Fixed | Sidecar |
|
||||
| UF-062 | The connector suggestion looks for `vault.db`, which never exists | Fixed | Sidecar |
|
||||
| UF-063 | `/config` and `/preferences` never run `/settings` | Fixed | Agent, commands |
|
||||
@@ -605,12 +605,12 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
|
||||
- Recommendation: generate the notices in the main project too, add the file to `bundle.resources` and link it from the About screen, and keep a CI license check. The licensing review decides how the LGPL source offer is made.
|
||||
|
||||
### UF-060. The sidecar ships `buffers` 0.1.1, which has no license
|
||||
- Status: Open
|
||||
- Status: Fixed
|
||||
- Found: 2026-11-01
|
||||
- Where: at commit `b20b138`, `packages/server/package.json:37` (`exceljs` ^4.4.0); dependency path `exceljs > unzipper@0.10.14 > binary@0.3.0 > buffers@0.1.1`
|
||||
- Symptom: `buffers` 0.1.1 has no `license` field, no license file and no license statement in its README. Without a license grant the code may not be redistributed, yet `stage-sidecar-deps.mjs` copies it into `resources/node_modules` of every desktop installer.
|
||||
- Cause: `exceljs` 4.4.0 still depends on `unzipper` 0.10, which pulls in the unmaintained `binary` and `buffers` packages.
|
||||
- What we did: nothing in the code yet. The OSS license gate lists it as an exception pending the licensing review, so the issue shows on every run.
|
||||
- What we did: an npm override (`"exceljs": { "unzipper": "0.12.3" }` in the root `package.json`) moves `exceljs` to `unzipper` 0.12.3, the version `whatsapp-web.js` already uses; it no longer depends on `binary`, so `binary`, `buffers`, `chainsaw` and `traverse` leave the tree and the installers. Waggle writes workbooks with `xlsx.writeFile` and reads uploads with `xlsx.load` (JSZip); `unzipper` serves only the streaming reader, which Waggle does not call. Writing and loading were checked after the change, and the license gate no longer needs an exception.
|
||||
- Recommendation: remove the dependency, for example with an npm override to a newer `unzipper` release if one no longer depends on `binary` (check that `exceljs` still reads workbooks), or ask the author for a license.
|
||||
|
||||
### UF-061. Key messages send users to "Settings > API Keys", which does not exist
|
||||
|
||||
Reference in New Issue
Block a user