fix(server): close the memory recall step when nothing is found or recall fails (UF-051)
Only a successful recall reported its outcome, so an empty or failed recall left "Recalling relevant memories..." as the last step after the answer. Both cases now send a closing step and the turn goes on.
This commit is contained in:
@@ -79,6 +79,7 @@ Baseline: commit `b20b138` of `git.os-dev.tech/oleg.m/waggle-os`.
|
||||
| UF-048 | The sidebar account row sits off-center at the bottom | Fixed | Web UI |
|
||||
| UF-049 | The workspace title stretches when switching tabs | Fixed | Web UI |
|
||||
| UF-050 | The chat activity card always claims memory, web and files | Fixed | Web UI, chat |
|
||||
| UF-051 | The memory recall step looks unfinished after the answer | Fixed | Sidecar, chat, memory |
|
||||
|
||||
## Entries
|
||||
|
||||
@@ -505,3 +506,12 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
|
||||
- Cause: the headline is a fixed string; only the step count beside it comes from the turn.
|
||||
- What we did: the headline is built from the turn itself: memory when a memory tool ran or the server reported recall or saving, the web for search, fetch and browser tools, files for file tools. A turn that touched none of them reads "Working" or "Done". Tests cover a plain turn and a web-and-files turn.
|
||||
- Recommendation: apply the same change in the main project.
|
||||
|
||||
### UF-051. The memory recall step looks unfinished after the answer
|
||||
- Status: Fixed
|
||||
- Found: 2026-10-26
|
||||
- Where: at commit `b20b138`, `packages/server/src/local/routes/chat.ts:1923` (the "Recalling relevant memories..." step), `:1962` (no memories found) and the empty `catch` after it
|
||||
- Symptom: when memory has nothing relevant, or the recall fails, the last line of the activity card is "Recalling relevant memories...", so the search looks like it is still running after the answer has arrived.
|
||||
- Cause: only the branch that finds memories sends a closing step ("Recalled N relevant memories."). The empty branch sends just a tool result, and a failed recall sends nothing.
|
||||
- What we did: the empty branch sends "No relevant memories found." and a failed recall sends "Could not search memory. Continuing without it." with an error tool result, and the turn goes on. A server test covers both cases and fails without the change.
|
||||
- Recommendation: apply the same change in the main project.
|
||||
|
||||
Reference in New Issue
Block a user