test(agent): move the agent suites onto the memory contract (P1.5)
Rewrites the orchestrator, recall, compaction, save_memory and assembler suites for MemoryStore (createInMemoryMemoryStore; mem0 with the word embedder for the M3b integration test), string ids, async prompt building and setWorkspace(). Creation times are set with fake timers, since a write cannot set its own. Stores of Waggle's own data (identity, traces) are built on WaggleDB; the session-manager stubs use the new create() signature. Kept behaviour: importance lane (cap, active scope, temporary exclusion), profile and event lanes, date window and its fallback, catch-up, injection blocking of recall and preloaded context, autosave safety, decision consent, compaction update-in-place, reranker wiring. New tests: recall with a workspace active versus personal only; fetchRecentMemories ordering; toRecallFrame; context loader; save_memory routing, dedup, rate limit, dramatic-claim downgrade and contradiction scope; search_memory and search_all_workspaces; pattern write-back kinds, scopes and sign gate; read_other_workspace; reranker off unless WAGGLE_RERANKER=1, wider rerank pool, failure fallbacks. Deleted, because the behaviour is gone: - w46-rawdetail-recall.test.ts: the raw-turn (RAWDETAIL) recall lane. - orchestrator.test.ts, query_knowledge (3 tests) and the recall-hardening M4 "Key Knowledge" test: the knowledge graph is not in v1 (ADR-0002). - orchestrator-context-frames "profile override": scoring profiles. - Assertions on I/P frame types, GOP sessions, FTS rows, the "Memory Facts" lane, cognify stages and session/entity counts were replaced by the equivalent contract-level checks.
This commit is contained in:
@@ -1,8 +1,7 @@
|
||||
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
||||
import { MindDB } from '@waggle/core';
|
||||
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
||||
import { createInMemoryMemoryStore, PERSONAL_SCOPE, type MemoryStore } from '@waggle/memory-contract';
|
||||
import { Orchestrator } from '../src/orchestrator.js';
|
||||
import { PromptAssembler, type RecalledMemory } from '../src/prompt-assembler.js';
|
||||
import { MockEmbedder } from '../../hive-mind-core/tests/mind/helpers/mock-embedder.js';
|
||||
|
||||
/**
|
||||
* W4.5 — PromptAssembler recall fixes (plan §3 bug #9):
|
||||
@@ -20,7 +19,7 @@ describe('W4.5 — assembler consumes pre-rendered recall', () => {
|
||||
workspace: [],
|
||||
personal: [],
|
||||
scanSafe: true,
|
||||
renderedText: '# Recalled Memories\n## Memory Facts\n- [2026-05-07] User preference: Ana prefers dark mode',
|
||||
renderedText: '# Recalled Memories\n## Personal Memory\n- [2026-05-07, normal] User preference: Ana prefers dark mode',
|
||||
};
|
||||
const out = new PromptAssembler().assemble({
|
||||
corePrompt: 'You are Waggle.',
|
||||
@@ -30,7 +29,7 @@ describe('W4.5 — assembler consumes pre-rendered recall', () => {
|
||||
query: 'dark mode?',
|
||||
tier: 'standard',
|
||||
}, {});
|
||||
expect(out.system).toContain('## Memory Facts');
|
||||
expect(out.system).toContain('## Personal Memory');
|
||||
expect(out.system).toContain('Ana prefers dark mode');
|
||||
expect(out.debug.sectionsIncluded).toContain('Recalled memory');
|
||||
});
|
||||
@@ -55,33 +54,34 @@ describe('W4.5 — assembler consumes pre-rendered recall', () => {
|
||||
});
|
||||
|
||||
describe('W4.5 — buildAssembledPrompt skips searches when recalledText given', () => {
|
||||
let db: MindDB;
|
||||
let memory: MemoryStore;
|
||||
let orchestrator: Orchestrator;
|
||||
|
||||
beforeEach(() => {
|
||||
db = new MindDB(':memory:');
|
||||
orchestrator = new Orchestrator({ db, embedder: new MockEmbedder() });
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
db.close();
|
||||
memory = createInMemoryMemoryStore();
|
||||
orchestrator = new Orchestrator({ memory });
|
||||
});
|
||||
|
||||
it('uses the provided multi-lane block without re-running searches', async () => {
|
||||
// Spy on the embedder: vectorSearch embeds the query on every search.
|
||||
// With recalledText provided, buildAssembledPrompt must not search.
|
||||
const embedder = new MockEmbedder();
|
||||
let embeds = 0;
|
||||
const origEmbed = embedder.embed.bind(embedder);
|
||||
embedder.embed = async (text: string) => { embeds++; return origEmbed(text); };
|
||||
const orch = new Orchestrator({ db, embedder });
|
||||
await memory.remember({ scope: PERSONAL_SCOPE, text: 'Ana prefers dark mode' });
|
||||
const search = vi.spyOn(memory, 'search');
|
||||
|
||||
const assembled = await orch.buildAssembledPrompt('dark mode?', null, {
|
||||
recalledText: '# Recalled Memories\n## Profiles\n- Ana: designer in Belgrade\n## Memory Facts\n- [2026-05-07] prefers dark mode',
|
||||
const assembled = await orchestrator.buildAssembledPrompt('dark mode?', null, {
|
||||
recalledText: '# Recalled Memories\n## Profiles\n- Ana: designer in Belgrade\n## Events (chronological)\n- [2026-05-07] Ana visited the dentist',
|
||||
});
|
||||
expect(assembled.system).toContain('## Profiles');
|
||||
expect(assembled.system).toContain('designer in Belgrade');
|
||||
expect(embeds).toBe(0); // no semantic search ran
|
||||
expect(search).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('searches personal and workspace memory itself when no recalledText is given', async () => {
|
||||
await memory.remember({ scope: PERSONAL_SCOPE, text: 'Ana prefers dark mode' });
|
||||
orchestrator.setWorkspace('ws-1');
|
||||
const search = vi.spyOn(memory, 'search');
|
||||
|
||||
const assembled = await orchestrator.buildAssembledPrompt('dark mode?', null);
|
||||
expect(search).toHaveBeenCalledTimes(2);
|
||||
expect(assembled.system).toContain('Ana prefers dark mode');
|
||||
});
|
||||
|
||||
it('empty recalledText means no recall section (recall was empty/blocked)', async () => {
|
||||
|
||||
Reference in New Issue
Block a user