Merge P2.3: license gate and third-party notices

# Conflicts:
#	docs/oss/upstream-fixes.md
This commit is contained in:
shumeiko.it
2026-11-01 01:17:28 +01:00
20 changed files with 29678 additions and 22 deletions

View File

@@ -87,6 +87,8 @@ Baseline: commit `b20b138` of the main Waggle repository.
| UF-056 | Home calls the last 24 hours "While you slept" | Fixed | Web UI |
| UF-057 | At phone width the sidebar rail takes a fifth of the screen | Fixed | Web UI |
| UF-058 | The mock-embedding warning names a variable Waggle does not read | Fixed | Sidecar, embeddings |
| UF-059 | Installers ship third-party code without its notices | Open | Licensing, packaging |
| UF-060 | The sidecar ships `buffers` 0.1.1, which has no license | Open | Licensing |
## Entries
@@ -585,3 +587,21 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
- Cause: the banner was written for the hive-mind CLI, which reads `HIVE_MIND_EMBEDDING_PROVIDER`; Waggle reuses the provider factory but reads `EMBEDDING_PROVIDER`.
- What we did: the banner in `packages/core/src/embeddings/embedding-provider.ts` now suggests `EMBEDDING_PROVIDER=inprocess`. A test checks the banner text.
- Recommendation: name `EMBEDDING_PROVIDER` in the banner when the factory runs inside Waggle, or let the caller pass the variable name.
### UF-059. Installers ship third-party code without its notices
- Status: Open
- Found: 2026-11-01
- Where: at commit `b20b138`, `app/src-tauri/tauri.conf.json:16` (`bundle.resources`); `scripts/build-sidecar.mjs` (esbuild bundle of `service.js`); the Vite build of `apps/web`; `app/src-tauri/Cargo.toml`
- Symptom: the desktop installers contain no list of the third-party components and no copy of their license texts. `service.js` inlines about 90 npm packages, the web UI bundle inlines about 300, and the Tauri executable links about 330 Rust crates; most of their licenses (MIT, BSD, Apache-2.0) require the notice to travel with the copies. The LGPL-3.0 libvips libraries that sharp loads (`@img/sharp-libvips-*`, the libvips DLLs in `@img/sharp-win32-x64`) carry no license file of their own, so the installers ship them without the LGPL and GPL texts and without a pointer to their source. Only the packages staged whole into `resources/node_modules` keep their own license files.
- Cause: no step of the build collects third-party notices, and transitive licenses were not checked.
- What we did: the OSS edition generates `THIRD_PARTY_NOTICES.md` with `scripts/generate-third-party-notices.mjs` (the sidecar and web UI closures, the Node.js runtime, the Rust crates, the license texts, and a section on the LGPL, MPL and OFL conditions), and CI runs a license gate (`npm run check:licenses`, cargo-deny with `app/src-tauri/deny.toml`). The notices file is not yet copied into the installers.
- Recommendation: generate the notices in the main project too, add the file to `bundle.resources` and link it from the About screen, and keep a CI license check. The licensing review decides how the LGPL source offer is made.
### UF-060. The sidecar ships `buffers` 0.1.1, which has no license
- Status: Open
- Found: 2026-11-01
- Where: at commit `b20b138`, `packages/server/package.json:37` (`exceljs` ^4.4.0); dependency path `exceljs > unzipper@0.10.14 > binary@0.3.0 > buffers@0.1.1`
- Symptom: `buffers` 0.1.1 has no `license` field, no license file and no license statement in its README. Without a license grant the code may not be redistributed, yet `stage-sidecar-deps.mjs` copies it into `resources/node_modules` of every desktop installer.
- Cause: `exceljs` 4.4.0 still depends on `unzipper` 0.10, which pulls in the unmaintained `binary` and `buffers` packages.
- What we did: nothing in the code yet. The OSS license gate lists it as an exception pending the licensing review, so the issue shows on every run.
- Recommendation: remove the dependency, for example with an npm override to a newer `unzipper` release if one no longer depends on `binary` (check that `exceljs` still reads workbooks), or ask the author for a license.