From 727c75665145ec5436ee1b687ea0b3b1417208be Mon Sep 17 00:00:00 2001 From: "shumeiko.it" Date: Sun, 1 Nov 2026 11:06:43 +0100 Subject: [PATCH] refactor: route Best fit proposals to personas only The executor router could propose Claude Code, Codex or Hermes and dispatch the task as a Waggle Room run through POST /api/tools/run, which is gone with the collaboration runtime. Confirming such a proposal could only fail. - ExecutorRegistry offers the five v1 personas; it no longer detects external tools. - Route proposals dispatch persona chat turns only. The memory brief and its egress disclosure existed only for external executors, so executor-brief.ts, the egress fields and removeFrameIds go too. - RouteProposalCard drops the memory disclosure, "Run without memory" and the link to an external run in the Room. --- .../os/apps/chat-blocks/RouteProposalCard.tsx | 132 ++--------- apps/web/src/lib/route-proposals.ts | 29 +-- .../web/src/test/route-proposal-card.test.tsx | 113 ++------- .../src/test/route-proposals-adapter.test.ts | 22 +- packages/server/src/local/executor-brief.ts | 180 --------------- .../server/src/local/executor-registry.ts | 74 +----- packages/server/src/local/index.ts | 2 - .../src/local/routes/route-proposals.ts | 154 +++---------- .../server/tests/local/executor-brief.test.ts | 216 ----------------- .../tests/local/executor-registry.test.ts | 83 +------ .../tests/local/route-proposals.test.ts | 218 +++--------------- 11 files changed, 121 insertions(+), 1102 deletions(-) delete mode 100644 packages/server/src/local/executor-brief.ts delete mode 100644 packages/server/tests/local/executor-brief.test.ts diff --git a/apps/web/src/components/os/apps/chat-blocks/RouteProposalCard.tsx b/apps/web/src/components/os/apps/chat-blocks/RouteProposalCard.tsx index 4911111..ed3f1a4 100644 --- a/apps/web/src/components/os/apps/chat-blocks/RouteProposalCard.tsx +++ b/apps/web/src/components/os/apps/chat-blocks/RouteProposalCard.tsx @@ -1,6 +1,6 @@ import { useEffect, useState } from 'react'; import { - Route, Loader2, CheckCircle2, XCircle, X, ChevronDown, ShieldAlert, ExternalLink, + Route, Loader2, CheckCircle2, XCircle, } from 'lucide-react'; import { adapter } from '@/lib/adapter'; import type { @@ -38,8 +38,6 @@ function revalidationReason(err: unknown): string | null { */ export default function RouteProposalCard({ proposal, onDispatched, onRePropose }: RouteProposalCardProps) { const [phase, setPhase] = useState('proposed'); - const [egressOpen, setEgressOpen] = useState(false); - const [removedFrameIds, setRemovedFrameIds] = useState([]); const [executorId, setExecutorId] = useState(proposal.selected?.id ?? ''); const [dispatchResult, setDispatchResult] = useState(null); const [errorReason, setErrorReason] = useState(null); @@ -48,32 +46,16 @@ export default function RouteProposalCard({ proposal, onDispatched, onRePropose // inherit the previous card's phase or stale executor selection. useEffect(() => { setPhase('proposed'); - setEgressOpen(false); - setRemovedFrameIds([]); setExecutorId(proposal.selected?.id ?? ''); setDispatchResult(null); setErrorReason(null); }, [proposal.routeDecisionId, proposal.selected?.id]); - const blocked = proposal.egress === null && proposal.briefBlocked === true; - const egressItems = proposal.egress?.items ?? []; - const remainingItems = egressItems.filter(i => !removedFrameIds.includes(i.frameId)); - - const removeFrame = (frameId: string) => { - setRemovedFrameIds(prev => (prev.includes(frameId) ? prev : [...prev, frameId])); - }; - - const removeAllFrames = () => { - setRemovedFrameIds(egressItems.map(i => i.frameId)); - }; - - const confirm = async (opts?: { withoutMemory?: boolean }) => { + const confirm = async () => { setPhase('dispatching'); setErrorReason(null); - const removeIds = opts?.withoutMemory ? egressItems.map(i => i.frameId) : removedFrameIds; const body: RouteProposalConfirmBody = { ...(executorId && executorId !== proposal.selected?.id ? { executorId } : {}), - ...(removeIds.length > 0 ? { removeFrameIds: removeIds } : {}), }; try { const result = await adapter.routeProposals.confirm(proposal.routeDecisionId, body); @@ -134,73 +116,8 @@ export default function RouteProposalCard({ proposal, onDispatched, onRePropose

)} - {/* Blocked brief — B1 injection gate: run-without-memory only */} - {blocked && phase !== 'dispatched' && ( -
- - - Memory context was blocked by the safety scan - {proposal.briefBlockedReason ? ` (${proposal.briefBlockedReason})` : ''}. This task can - only run without memory. - -
- )} - - {/* Egress disclosure — only when a brief accompanies the dispatch */} - {!blocked && proposal.egress && phase !== 'dispatched' && ( -
- - {egressOpen && ( -
    - {remainingItems.map(item => ( -
  • - {item.date} · {item.source} - {item.preview} - -
  • - ))} -
- )} - {remainingItems.length > 0 && ( - - )} -
- )} - {/* Alternatives override — rejected greyed with reason tooltip */} - {!blocked && phase === 'proposed' && proposal.selected + {phase === 'proposed' && proposal.selected && (proposal.alternatives.length > 0 || proposal.rejected.length > 0) && (