fix: never greet the user by the assistant's default name (UF-055)

Home and the sidebar read the user's name from the identity row, which the
sidecar fills with the assistant's identity named Waggle. Both now use the
profile name, with the identity name as a fallback that skips the default.
This commit is contained in:
shumeiko.it
2026-10-27 14:24:35 +01:00
parent c2998f1a6b
commit 659c84bee2
8 changed files with 111 additions and 13 deletions

View File

@@ -83,6 +83,7 @@ Baseline: commit `b20b138` of `git.os-dev.tech/oleg.m/waggle-os`.
| UF-052 | Home offers the same workspace twice | Fixed | Web UI |
| UF-053 | The user's chat bubble is squared on the wrong corner | Fixed | Web UI, chat |
| UF-054 | Settings and the status bar name different default models | Fixed | Web UI, models |
| UF-055 | Home greets the user by the assistant's name | Fixed | Sidecar, Web UI |
## Entries
@@ -545,3 +546,12 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
- Cause: both are true. The primary has no API key, so the server's usable-model check routes new chats to the local model, and the status bar shows that model. Model Pilot only shows the configured primary and never says it cannot answer.
- What we did: when the primary's provider needs a key the vault lacks, Model Pilot says so under Primary and names the model new chats use until a key is added. Settings reads that model from the server. A test covers the keyless, unknown and keyed cases.
- Recommendation: apply the same change in the main project.
### UF-055. Home greets the user by the assistant's name
- Status: Fixed
- Found: 2026-10-14
- Where: at commit `b20b138`, `packages/server/src/local/routes/home.ts:265` (the greeting name) and `apps/web/src/components/os/AppShell.tsx:206` (the sidebar account row); the default comes from `packages/agent/src/auto-identity.ts`
- Symptom: a user who left their name empty during onboarding sees "Welcome, Waggle" on Home and "Waggle" as the account name in the sidebar.
- Cause: both read the name from the identity row. At startup the sidecar fills that row with the assistant's own identity, named "Waggle", and onboarding only overwrites it when the user types a name.
- What we did: the name comes from profile.json, which the user states. The identity row is a fallback and its default assistant name is ignored, so with no name the greeting has none and the account row reads "Account". The agent package exports the default name as `DEFAULT_AGENT_NAME`. Server and web tests cover a profile name, a real identity name and the default.
- Recommendation: apply the same change in the main project, and keep the assistant's identity apart from the user's.