diff --git a/apps/web/src/components/os/Sidebar.tsx b/apps/web/src/components/os/Sidebar.tsx index 198b58e..57f8383 100644 --- a/apps/web/src/components/os/Sidebar.tsx +++ b/apps/web/src/components/os/Sidebar.tsx @@ -236,7 +236,9 @@ const Sidebar = ({ data-testid="sidebar-user" aria-label="Account and settings" onClick={() => navigate("/settings")} - className="mt-1.5 flex items-center justify-center gap-2.5 border-t border-[var(--line-soft)] px-2.5 py-2 text-left lg:justify-start" + // pt-3.5 matches the nav's own bottom padding, so the row sits centered + // between the divider and the window edge. + className="mt-1.5 flex items-center justify-center gap-2.5 border-t border-[var(--line-soft)] px-2.5 pb-0 pt-3.5 text-left lg:justify-start" > {initialOf(userName, "W")} diff --git a/apps/web/src/components/os/overlays/CommandCenter.tsx b/apps/web/src/components/os/overlays/CommandCenter.tsx index 4c4ec94..f75437b 100644 --- a/apps/web/src/components/os/overlays/CommandCenter.tsx +++ b/apps/web/src/components/os/overlays/CommandCenter.tsx @@ -565,15 +565,16 @@ const CommandCenter = ({ open, onClose, onNavigate, onExecute, workspaceId, cata > {/* Query input */}
+ {/* Padding keeps the text clear of the focus ring, which outlines the field. */} {searching && } diff --git a/apps/web/src/test/p7-b3-command-center.test.tsx b/apps/web/src/test/p7-b3-command-center.test.tsx index 34ebafd..4625d2b 100644 --- a/apps/web/src/test/p7-b3-command-center.test.tsx +++ b/apps/web/src/test/p7-b3-command-center.test.tsx @@ -48,6 +48,10 @@ describe('P7/B3 — Command Center error containment', () => { expect(input.className).toContain('focus-visible:ring-2'); expect(input.className).toContain('focus-visible:ring-[var(--focus-ring)]'); + // The ring outlines the field itself, so the text needs inner padding (UF-047). + expect(input.className).not.toMatch(/\bp-0\b/); + expect(input.className).toContain('px-2.5'); + expect(input.className).not.toContain('ring-offset'); }); it('renders catalog subtitles as their own truncating line for mobile fit', async () => { diff --git a/docs/oss/upstream-fixes.md b/docs/oss/upstream-fixes.md index ae95a4d..85daed4 100644 --- a/docs/oss/upstream-fixes.md +++ b/docs/oss/upstream-fixes.md @@ -75,6 +75,8 @@ Baseline: commit `b20b138` of `git.os-dev.tech/oleg.m/waggle-os`. | UF-044 | A working API key shows as not responding, and other internal model calls fail | Fixed | Sidecar, models, auth | | UF-045 | Generating a persona from a description calls a route that does not exist | Fixed | Sidecar, agents | | UF-046 | On macOS and Linux the desktop app kills the sidecar without its shutdown | Fixed | Desktop shell, sidecar | +| UF-047 | The command palette's search text touches its focus outline | Fixed | Web UI | +| UF-048 | The sidebar account row sits off-center at the bottom | Fixed | Web UI | ## Entries @@ -465,3 +467,21 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14. - Cause: `Child::kill()` sends SIGKILL on Unix, so the sidecar gets no chance to shut down. Windows is not affected: there the sidecar runs in a job object that ends its whole process tree. - What we did: on Unix the shell now sends SIGTERM, waits up to 5 seconds for the sidecar to exit (it exits on SIGTERM since UF-041) and only then sends SIGKILL; Rust tests cover both paths. For the crash case, where no shutdown runs at all, the WhatsApp channel now stops a browser left over from an earlier run before it starts its own (`whatsapp-profile-lock.ts`): it reads the profile's `SingletonLock`, and stops the process only if its command line uses this profile and the process that started it is gone. A browser that another running Waggle server still owns is left alone, and the channel says so instead of retrying. - Recommendation: stop the sidecar with SIGTERM first in the main project as well. + +### UF-047. The command palette's search text touches its focus outline +- Status: Fixed +- Found: 2026-10-26 +- Where: at commit `b20b138`, `apps/web/src/components/os/overlays/CommandCenter.tsx:586` (the search input under the placeholder at :585) +- Symptom: when the ⌘K search field has keyboard focus, the amber ring runs right against the text, so the first letter and the end of the placeholder look cut off. +- Cause: the input has no padding (`p-0`) but draws its own `focus-visible:ring-2` with a 2px offset, so the ring outlines the bare text. +- What we did: the input has inner padding (`px-2.5 py-1.5`) and no ring offset, so the ring reads as the field's outline; the gap to the search icon shrinks to keep the text where it was. The palette test now checks the padding as well as the ring. +- Recommendation: apply the same change in the main project. + +### UF-048. The sidebar account row sits off-center at the bottom +- Status: Fixed +- Found: 2026-10-26 +- Where: at commit `b20b138`, `apps/web/src/components/os/Sidebar.tsx:201` (the account row, `py-2`), inside the nav's `py-3.5` +- Symptom: under the divider, the account row has 8px above its content and 22px below it, so it looks pinned to the divider with an odd gap underneath. +- Cause: the row's bottom padding adds to the nav's own 14px bottom padding. +- What we did: the row has 14px above its content and none below, so the nav's padding gives the same 14px underneath. +- Recommendation: apply the same change in the main project.