feat(licenses): meet the LGPL notice and source terms for libvips and node-webpmux

The notices now carry the LGPL-3.0 and GPL-3.0 texts from
scripts/license-texts (the LGPL text byte-identical to gnu.org's, the GPL
text as the Rust toolchain ships it), whatever the dependencies ship.
The LGPL section names each component with its exact version, says it
ships unmodified as a separate library, and gives the upstream source
release of that version: sharp-libvips v1.3.2 and libvips v8.18.3 for
the libvips packages, sharp v0.35.3 for @img/sharp-win32-x64, the npm
package of node-webpmux 3.2.1. The libraries built into libvips are
listed with their versions from versions.json. Versions and repository
URLs come from the lockfile and the installed packages.

The LGPL exceptions of the license gate are no longer pending: the
project owner left these items to us. A test checks the texts, the LGPL
rows and the Apache-2.0 files against the committed notices. UF-059 is
fixed.
This commit is contained in:
shumeiko.it
2026-11-04 10:34:32 +01:00
parent 58535a580f
commit 35bf8e26bd
8 changed files with 829 additions and 113 deletions

View File

@@ -45,7 +45,8 @@ Implemented in P1.7 with `whatsapp-web.js` 1.34.7 (Puppeteer 24).
`@puppeteer/browsers`, `chromium-bidi`, `webdriver-bidi-protocol`), BSD (`devtools-protocol`,
`extract-zip`), MIT and ISC for the rest, and LGPL-3.0-or-later for `node-webpmux`, a
required dependency of whatsapp-web.js that it loads on startup for sticker metadata. It
ships as a separate, unmodified package. The licensing review has to accept it.
ships as a separate, unmodified package; `THIRD_PARTY_NOTICES.md` carries its LGPL notice,
the license texts and its source location (settled on 2026-11-04, no owner review needed).
- The client is unofficial. Settings warns that WhatsApp may block the account and
recommends a secondary number.
- Risk: whatsapp-web.js awaits page work inside browser event listeners (for example

View File

@@ -87,7 +87,7 @@ Baseline: commit `b20b138` of the main Waggle repository.
| UF-056 | Home calls the last 24 hours "While you slept" | Fixed | Web UI |
| UF-057 | At phone width the sidebar rail takes a fifth of the screen | Fixed | Web UI |
| UF-058 | The mock-embedding warning names a variable Waggle does not read | Fixed | Sidecar, embeddings |
| UF-059 | Installers ship third-party code without its notices | Open | Licensing, packaging |
| UF-059 | Installers ship third-party code without its notices | Fixed | Licensing, packaging |
| UF-060 | The sidecar ships `buffers` 0.1.1, which has no license | Fixed | Licensing |
| UF-061 | Key messages send users to "Settings > API Keys", which does not exist | Fixed | Sidecar |
| UF-062 | The connector suggestion looks for `vault.db`, which never exists | Fixed | Sidecar |
@@ -251,7 +251,7 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
- Where: `packages/server/package.json:30` and `packages/launcher/package.json:42` (`@whiskeysockets/baileys` ^7.0.0-rc13); `packages/server/src/local/channels/whatsapp-adapter.ts:118,260`; `scripts/build-sidecar.mjs` (`EXTERNAL` list)
- Symptom: Baileys itself is MIT, but it depends on `libsignal` 6.0.0 (`WhiskeySockets/libsignal-node`), which is GPL-3.0. Baileys is not in the esbuild `EXTERNAL` list, so the sidecar build bundles Baileys together with `libsignal` into `service.js`, which ships inside the desktop installer. This follows from the build configuration; we have not inspected a built installer.
- Cause: the licenses of transitive dependencies are not checked.
- What we did: the OSS edition replaces Baileys with `whatsapp-web.js` (Apache-2.0), per Egzakta decision Q5 (P1.7, ADR-0005). `libsignal` and Baileys are gone from the lockfile, and `whatsapp-web.js` stays outside the esbuild bundle. Its own dependency `node-webpmux` is LGPL-3.0-or-later and ships as a separate package; that is for the license review.
- What we did: the OSS edition replaces Baileys with `whatsapp-web.js` (Apache-2.0), per Egzakta decision Q5 (P1.7, ADR-0005). `libsignal` and Baileys are gone from the lockfile, and `whatsapp-web.js` stays outside the esbuild bundle. Its own dependency `node-webpmux` is LGPL-3.0-or-later and ships as a separate, unmodified package; `THIRD_PARTY_NOTICES.md` carries its LGPL notice, texts and source location (UF-059).
- Recommendation: include this in the license review (Q6). Shipping GPL-3.0 code inside a binary distributed under other terms is a compliance risk that needs a legal opinion. Options: replace Baileys in the main product as well, or move the WhatsApp connector into a separately installed component. Add a license check for transitive dependencies to CI.
### UF-021. Settings visual-regression baseline is ignored by git
@@ -597,13 +597,13 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
- Recommendation: name `EMBEDDING_PROVIDER` in the banner when the factory runs inside Waggle, or let the caller pass the variable name.
### UF-059. Installers ship third-party code without its notices
- Status: Open
- Status: Fixed
- Found: 2026-11-01
- Where: at commit `b20b138`, `app/src-tauri/tauri.conf.json:16` (`bundle.resources`); `scripts/build-sidecar.mjs` (esbuild bundle of `service.js`); the Vite build of `apps/web`; `app/src-tauri/Cargo.toml`
- Symptom: the desktop installers contain no list of the third-party components and no copy of their license texts. `service.js` inlines about 90 npm packages, the web UI bundle inlines about 300, and the Tauri executable links about 330 Rust crates; most of their licenses (MIT, BSD, Apache-2.0) require the notice to travel with the copies. The LGPL-3.0 libvips libraries that sharp loads (`@img/sharp-libvips-*`, the libvips DLLs in `@img/sharp-win32-x64`) carry no license file of their own, so the installers ship them without the LGPL and GPL texts and without a pointer to their source. Only the packages staged whole into `resources/node_modules` keep their own license files.
- Cause: no step of the build collects third-party notices, and transitive licenses were not checked.
- What we did: the OSS edition generates `THIRD_PARTY_NOTICES.md` with `scripts/generate-third-party-notices.mjs` (the sidecar and web UI closures, the Node.js runtime, the Rust crates, the license texts, and a section on the LGPL, MPL and OFL conditions), and CI runs a license gate (`npm run check:licenses`, cargo-deny with `app/src-tauri/deny.toml`). The notices file is not yet copied into the installers.
- Recommendation: generate the notices in the main project too, add the file to `bundle.resources` and link it from the About screen, and keep a CI license check. The licensing review decides how the LGPL source offer is made.
- What we did: the OSS edition generates `THIRD_PARTY_NOTICES.md` with `scripts/generate-third-party-notices.mjs` (the sidecar and web UI closures, the Node.js runtime, the Rust crates, the license texts, and a section on the LGPL, MPL and OFL conditions), and CI runs a license gate (`npm run check:licenses`, cargo-deny with `app/src-tauri/deny.toml`). On 2026-11-04 the fix was completed: `build-sidecar.mjs` copies `LICENSE` and `THIRD_PARTY_NOTICES.md` next to `service.js` (and fails without them), so the `resources/*` glob of `bundle.resources` puts them into every desktop installer and `build-server-archive.mjs` packs them into the server archive; the sidecar serves both read-only (`GET /api/legal/license`, `GET /api/legal/third-party-notices`, from the packaged copies or the repository root), and Settings > General > About opens them. The LGPL section now carries the canonical LGPL-3.0 and GPL-3.0 texts (`scripts/license-texts/`), names each LGPL component and the LGPL libraries inside libvips with their exact versions, states that they ship unmodified as separate libraries, and gives the upstream source release of each version.
- Recommendation: generate the notices in the main project too, add `LICENSE` and the notices file to `bundle.resources`, link them from Settings or an About screen, and keep a CI license check.
### UF-060. The sidecar ships `buffers` 0.1.1, which has no license
- Status: Fixed