refactor(agent): move the connector credential helpers out of VaultStore (P1.2)
getConnectorCredential, setConnectorCredential and setConnectorCredentialBundle are now plain functions over a SecretStore in packages/agent/src/connectors/connector-credentials.ts. The secret names, metadata layout and the rule that tokens never go into plaintext metadata are unchanged, so existing vault files keep working. A bundle still lands as one update: SecretStore gains writeBatch, which VaultStore applies with a single vault-file replacement. Connector tests seed a Map-backed SecretStore instead of mocking VaultStore methods; the helper tests from core and server moved to the agent package.
This commit is contained in:
@@ -1,21 +1,9 @@
|
||||
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
|
||||
import { ComposioConnector } from '../../src/connectors/composio-connector.js';
|
||||
import type { VaultStore } from '@waggle/core';
|
||||
import { createMemorySecretStore, seedCredential, type MockSecretStore } from '../helpers/memory-secret-store.js';
|
||||
|
||||
function createMockVault(cred?: { value: string; isExpired: boolean }): VaultStore {
|
||||
return {
|
||||
getConnectorCredential: vi.fn((id: string) => {
|
||||
if (id === 'composio' && cred) return { ...cred, type: 'api_key' };
|
||||
return null;
|
||||
}),
|
||||
get: vi.fn(() => null),
|
||||
set: vi.fn(),
|
||||
delete: vi.fn(),
|
||||
list: vi.fn(() => []),
|
||||
has: vi.fn(() => false),
|
||||
setConnectorCredential: vi.fn(),
|
||||
migrateFromConfig: vi.fn(() => 0),
|
||||
} as unknown as VaultStore;
|
||||
function createMockVault(cred?: { value: string; isExpired: boolean }): MockSecretStore {
|
||||
return createMemorySecretStore({ connectors: cred ? { composio: seedCredential(cred, 'api_key') } : {} });
|
||||
}
|
||||
|
||||
describe('ComposioConnector', () => {
|
||||
@@ -66,7 +54,7 @@ describe('ComposioConnector', () => {
|
||||
it('connect() retrieves API key from vault', async () => {
|
||||
const vault = createMockVault({ value: 'cmp_test_key', isExpired: false });
|
||||
await connector.connect(vault);
|
||||
expect(vault.getConnectorCredential).toHaveBeenCalledWith('composio');
|
||||
expect(vault.get).toHaveBeenCalledWith('connector:composio');
|
||||
});
|
||||
|
||||
it('execute returns error when not connected', async () => {
|
||||
|
||||
Reference in New Issue
Block a user