From 2e1999a3f613420161da77ab1f80f3e3c077e81e Mon Sep 17 00:00:00 2001 From: "shumeiko.it" Date: Tue, 20 Oct 2026 00:54:58 +0200 Subject: [PATCH] refactor: remove self-learning and the optimizer package (P1.4) Self-learning is excluded from the community edition (ADR-0004); the project owner reworks it separately. Cost tracking stays. - agent: delete behaviour evolution (evolve-schema, iterative GEPA, compose-evolution, evolution gates, orchestrator and deploy), improvement and correction detection, AgentLearning, the eval-dataset builder, optimization-capture and the agent_insights tool. Secret detection moves from eval-dataset to secret-patterns. The LLM wiring keeps only the Haiku adapter and judge call used by skill audit and hygiene, so @ax-llm/ax is now declared by agent instead of server. - server: delete /api/evolution/*, the evolution and optimizer services, GEPA expansion of the first chat message, the prompt_optimization and monthly_assessment jobs, the idle-session reviewer and its session-reviewer persona, prompt injection of past corrections and thumbs-down recorded as correction signals. Existing job rows of the removed types are ignored, not deleted. - core: delete OptimizationLogStore; stop re-exporting the improvement signal and evolution run stores. - web: delete the Evolution screen and the two job types in the automation editor. - delete packages/optimizer. Also logs UF-027 (self-learning loops read data nothing collects) and UF-028 (the Settings prompt-shape choice is ignored by chat). --- AGENTS.md | 13 +- .../src/components/os/apps/ApprovalsApp.tsx | 2 +- .../components/os/apps/MemoryCenterApp.tsx | 20 +- .../os/apps/memory/EvolutionTab.test.tsx | 253 ---- .../os/apps/memory/EvolutionTab.tsx | 1319 ----------------- .../components/os/overlays/CommandCenter.tsx | 2 +- apps/web/src/lib/cron-presets.ts | 14 +- apps/web/src/lib/persona-tier.test.ts | 8 - apps/web/src/test/lane-hm-hero-morph.test.tsx | 1 - .../src/test/p3-memory-center-app.test.tsx | 2 - ...0004-cost-tracking-in-self-learning-out.md | 32 +- docs/oss/upstream-fixes.md | 21 + package-lock.json | 14 +- packages/agent/package.json | 1 + packages/agent/src/agent-learning.ts | 194 --- packages/agent/src/behavioral-spec.ts | 6 +- packages/agent/src/compose-evolution.ts | 281 ---- packages/agent/src/correction-detector.ts | 199 --- packages/agent/src/eval-dataset.ts | 441 ------ packages/agent/src/evolution-deploy.ts | 299 ---- packages/agent/src/evolution-gates.ts | 316 ---- packages/agent/src/evolution-llm-wiring.ts | 264 +--- packages/agent/src/evolution-orchestrator.ts | 371 ----- packages/agent/src/evolve-schema.ts | 852 ----------- packages/agent/src/harness-trace-bridge.ts | 12 +- packages/agent/src/improvement-detector.ts | 249 ---- packages/agent/src/improvement-wiring.ts | 181 --- packages/agent/src/index.ts | 76 +- packages/agent/src/insights-tools.ts | 140 -- packages/agent/src/iterative-optimizer.ts | 626 -------- packages/agent/src/judge.ts | 10 +- packages/agent/src/optimization-capture.ts | 96 -- packages/agent/src/orchestrator.ts | 30 - packages/agent/src/persona-data.ts | 79 - packages/agent/src/prompt-loader.ts | 59 +- packages/agent/src/secret-patterns.ts | 57 + packages/agent/src/self-awareness.ts | 34 - packages/agent/src/skill-autoextract.ts | 21 - packages/agent/src/skill-redaction.ts | 4 +- packages/agent/src/skill-retirement.ts | 14 - packages/agent/src/skill-tools.ts | 34 +- packages/agent/src/tools.ts | 22 - .../agent/tests/compose-evolution.test.ts | 373 ----- .../agent/tests/correction-detector.test.ts | 204 --- packages/agent/tests/eval-dataset.test.ts | 348 ----- packages/agent/tests/evolution-deploy.test.ts | 372 ----- packages/agent/tests/evolution-gates.test.ts | 245 --- .../agent/tests/evolution-llm-wiring.test.ts | 282 ---- .../tests/evolution-orchestrator.test.ts | 447 ------ packages/agent/tests/evolve-schema.test.ts | 545 ------- .../agent/tests/improvement-detector.test.ts | 226 --- .../agent/tests/improvement-wiring.test.ts | 153 -- .../agent/tests/iterative-optimizer.test.ts | 655 -------- .../agent/tests/optimization-capture.test.ts | 280 ---- packages/agent/tests/personas.test.ts | 29 +- packages/agent/tests/promote-skill.test.ts | 18 +- packages/agent/tests/prompt-loader.test.ts | 48 +- .../agent/tests/save-memory-conflict.test.ts | 52 +- packages/agent/tests/secret-patterns.test.ts | 77 + packages/agent/tests/self-awareness.test.ts | 55 - .../agent/tests/skill-autoextract.test.ts | 20 - packages/agent/tests/skill-retirement.test.ts | 11 - packages/cli/src/repl.ts | 7 +- packages/core/package.json | 2 +- packages/core/src/cron-store.ts | 4 +- packages/core/src/index.ts | 11 +- packages/core/src/install-audit.ts | 2 +- packages/core/src/optimization-log.ts | 154 -- .../tests/integration/full-stack.test.ts | 18 - packages/optimizer/LICENSE | 5 - packages/optimizer/README.md | 41 - packages/optimizer/package.json | 18 - packages/optimizer/src/index.ts | 13 - packages/optimizer/src/optimizer.ts | 50 - packages/optimizer/src/signatures.ts | 69 - packages/optimizer/tests/optimizer.test.ts | 223 --- packages/optimizer/tsconfig.json | 21 - packages/optimizer/vitest.config.ts | 9 - packages/server/package.json | 1 - .../server/src/local/channels/chat-client.ts | 2 +- .../server/src/local/held-action-executor.ts | 10 +- packages/server/src/local/idle-watcher.ts | 344 ----- packages/server/src/local/index.ts | 348 +---- .../server/src/local/monthly-assessment.ts | 346 ----- .../server/src/local/proactive-handlers.ts | 14 - .../server/src/local/routes/chat-helpers.ts | 1 - packages/server/src/local/routes/chat.ts | 178 +-- packages/server/src/local/routes/evolution.ts | 661 --------- packages/server/src/local/routes/feedback.ts | 28 +- .../src/local/routes/workspace-context.ts | 3 +- .../server/src/local/security-middleware.ts | 6 - .../src/local/services/evolution-service.ts | 391 ----- .../src/local/services/optimizer-service.ts | 163 -- packages/server/src/local/setup-crons.ts | 2 - .../tests/behavioral-spec-active.test.ts | 104 +- .../server/tests/evolution-routes.test.ts | 386 ----- .../server/tests/evolution-run-route.test.ts | 397 ----- .../server/tests/local/automations.test.ts | 36 - .../server/tests/local/chat-helpers.test.ts | 1 - .../tests/local/feedback-routes.test.ts | 36 +- .../tests/local/gepa-optimization.test.ts | 196 --- .../server/tests/local/idle-watcher.test.ts | 287 ---- .../local/memory-write-lint-hook.test.ts | 13 +- .../tests/local/monthly-assessment.test.ts | 315 ---- .../persona-acceptance-prompt-budget.test.ts | 15 - .../tests/local/personas-routes.test.ts | 43 +- .../local/session-reviewer-persona.test.ts | 57 - .../server/tests/persona-tool-filter.test.ts | 2 +- .../tests/services/evolution-service.test.ts | 341 ----- scripts/check-workspace-deps.mjs | 10 +- tests/behaviors/waggle-journeys.test.ts | 7 +- tests/e2e/runtime-a11y.spec.ts | 1 - 112 files changed, 336 insertions(+), 16165 deletions(-) delete mode 100644 apps/web/src/components/os/apps/memory/EvolutionTab.test.tsx delete mode 100644 apps/web/src/components/os/apps/memory/EvolutionTab.tsx delete mode 100644 packages/agent/src/agent-learning.ts delete mode 100644 packages/agent/src/compose-evolution.ts delete mode 100644 packages/agent/src/correction-detector.ts delete mode 100644 packages/agent/src/eval-dataset.ts delete mode 100644 packages/agent/src/evolution-deploy.ts delete mode 100644 packages/agent/src/evolution-gates.ts delete mode 100644 packages/agent/src/evolution-orchestrator.ts delete mode 100644 packages/agent/src/evolve-schema.ts delete mode 100644 packages/agent/src/improvement-detector.ts delete mode 100644 packages/agent/src/improvement-wiring.ts delete mode 100644 packages/agent/src/insights-tools.ts delete mode 100644 packages/agent/src/iterative-optimizer.ts delete mode 100644 packages/agent/src/optimization-capture.ts create mode 100644 packages/agent/src/secret-patterns.ts delete mode 100644 packages/agent/tests/compose-evolution.test.ts delete mode 100644 packages/agent/tests/correction-detector.test.ts delete mode 100644 packages/agent/tests/eval-dataset.test.ts delete mode 100644 packages/agent/tests/evolution-deploy.test.ts delete mode 100644 packages/agent/tests/evolution-gates.test.ts delete mode 100644 packages/agent/tests/evolution-orchestrator.test.ts delete mode 100644 packages/agent/tests/evolve-schema.test.ts delete mode 100644 packages/agent/tests/improvement-detector.test.ts delete mode 100644 packages/agent/tests/improvement-wiring.test.ts delete mode 100644 packages/agent/tests/iterative-optimizer.test.ts delete mode 100644 packages/agent/tests/optimization-capture.test.ts create mode 100644 packages/agent/tests/secret-patterns.test.ts delete mode 100644 packages/core/src/optimization-log.ts delete mode 100644 packages/optimizer/LICENSE delete mode 100644 packages/optimizer/README.md delete mode 100644 packages/optimizer/package.json delete mode 100644 packages/optimizer/src/index.ts delete mode 100644 packages/optimizer/src/optimizer.ts delete mode 100644 packages/optimizer/src/signatures.ts delete mode 100644 packages/optimizer/tests/optimizer.test.ts delete mode 100644 packages/optimizer/tsconfig.json delete mode 100644 packages/optimizer/vitest.config.ts delete mode 100644 packages/server/src/local/idle-watcher.ts delete mode 100644 packages/server/src/local/monthly-assessment.ts delete mode 100644 packages/server/src/local/routes/evolution.ts delete mode 100644 packages/server/src/local/services/evolution-service.ts delete mode 100644 packages/server/src/local/services/optimizer-service.ts delete mode 100644 packages/server/tests/evolution-routes.test.ts delete mode 100644 packages/server/tests/evolution-run-route.test.ts delete mode 100644 packages/server/tests/local/gepa-optimization.test.ts delete mode 100644 packages/server/tests/local/idle-watcher.test.ts delete mode 100644 packages/server/tests/local/monthly-assessment.test.ts delete mode 100644 packages/server/tests/local/session-reviewer-persona.test.ts delete mode 100644 packages/server/tests/services/evolution-service.test.ts diff --git a/AGENTS.md b/AGENTS.md index 00d0972..e330014 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -11,8 +11,8 @@ ## 0. Where We Are This branch turns the commercial Waggle OS codebase into an open-source **community edition**. -The conversion is in progress: the code still contains tiers, Stripe, KVARK, team mode and the -hive-mind memory substrate. Work packages remove or replace them one by one. +The conversion is in progress: the code still contains team mode and the hive-mind memory +substrate. Work packages remove or replace them one by one. Sources of truth, in order: 1. The agreed scope ("Waggle OSS Agreed Scope Annex", held by the project owner). @@ -63,7 +63,6 @@ npm workspaces with the root `package-lock.json`. Node `^20.19.0 || >=22.12.0`. | `packages/agent`, `core`, `server`, `shared`, `sdk`, `weaver`, `marketplace`, `cli`, `launcher` | Keep. | | `packages/memory-contract`, `packages/memory-mem0` | Keep. The memory contract and its mem0 implementation (ADR-0007). | | `packages/waggle-dance`, `packages/worker` | Postponed: team mode stays in the repo, is not built or shipped (ADR-0003). | -| `packages/optimizer` | Excluded: part of self-learning (ADR-0004). Removed in P1.4. | | `packages/hive-mind-*`, `memory-mcp`, `wiki-compiler` | Excluded once P1.5 moves all memory access to the contract. | | `packages/admin-web`, `apps/www` | Excluded. | | `apps/browser-ext` | Not decided. Do not extend it. | @@ -94,10 +93,10 @@ packages/core/src/ # config, cron-store, file-store, vault, logger, te packages/shared/src/ # shared types, Zod schemas, MCP catalog ``` -To be removed by work packages, so do not build on them: `packages/shared/src/tiers.ts` -(P0.1), `packages/agent/src/kvark-tools.ts` and the evolution / improvement / correction -modules (P1.4), `packages/server/src/stripe/` and `packages/server/src/kvark/` (P1.1), -`packages/core/src/compliance/` and `install-audit.ts` (P1.2). +Already removed: tiers and Stripe (P0.1); KVARK, enterprise packs, the compliance +subsystem, self-learning and `packages/optimizer` (P1.4, P1.6, ADR-0004). Still to be +removed, so do not build on them: `install-audit.ts`, `team-sync` and `migration` in core +(P1.2), the team server runtime (P1.1). --- diff --git a/apps/web/src/components/os/apps/ApprovalsApp.tsx b/apps/web/src/components/os/apps/ApprovalsApp.tsx index 790f918..80e60df 100644 --- a/apps/web/src/components/os/apps/ApprovalsApp.tsx +++ b/apps/web/src/components/os/apps/ApprovalsApp.tsx @@ -94,7 +94,7 @@ function summarizeInput(input: Record): string { * approve blind: the approver sees the skill's name up front and can expand the * exact bytes `writeSkill` will persist before allowing it. `summarizeInput` * surfaces none of `{name, content}`, so without this the card showed only the - * tool name — a review-before-apply gap for the self-evolution loop. + * tool name — a review-before-apply gap for agent-authored skills. */ function SkillPreview({ name, content }: { name: string; content: string }) { const [expanded, setExpanded] = useState(false); diff --git a/apps/web/src/components/os/apps/MemoryCenterApp.tsx b/apps/web/src/components/os/apps/MemoryCenterApp.tsx index 60767b3..88bde75 100644 --- a/apps/web/src/components/os/apps/MemoryCenterApp.tsx +++ b/apps/web/src/components/os/apps/MemoryCenterApp.tsx @@ -1,6 +1,6 @@ import { useState } from 'react'; import { motion, useReducedMotion } from 'framer-motion'; -import { Brain, Clock, Network, Download, Activity, BookOpen, Sparkles, User, Briefcase, ShieldCheck, SlidersHorizontal, ChevronDown } from 'lucide-react'; +import { Brain, Clock, Network, Download, Activity, BookOpen, User, Briefcase, ShieldCheck, SlidersHorizontal, ChevronDown } from 'lucide-react'; import type { KGNode, KGEdge } from '@/lib/types'; import { HintTooltip } from '@/components/ui/hint-tooltip'; import { SPRING } from '@/lib/motion/tokens'; @@ -10,7 +10,6 @@ import KnowledgeGraphViewer from './memory/KnowledgeGraphViewer'; import HarvestTab from './memory/HarvestTab'; import WeaverPanel from './memory/WeaverPanel'; import WikiTab from './memory/WikiTab'; -import EvolutionTab from './memory/EvolutionTab'; import MemoryCenterTab from './memory/MemoryCenterTab'; import TimelineTab, { type TimelineTabProps } from './memory/TimelineTab'; import ImportReminderBanner from './memory/ImportReminderBanner'; @@ -23,7 +22,7 @@ import { useOnboarding } from '@/hooks/useOnboarding'; * Top-level structure is the ratified TWO-MIND SPLIT: "About you" reads the * Personal Mind; "About this work" reads the active workspace's Mind. The * per-mind list is MemoryCenterTab (reused, parameterized — D2). The legacy - * MemoryApp views (Timeline / Graph / Harvest / Weaver / Wiki / Evolution) + * MemoryApp views (Timeline / Graph / Harvest / Weaver / Wiki) * survive as secondary tabs after a divider — capability preserved, entry * restructured. Mind pills render only on the Memories tab: the legacy tabs * keep their own scoping (Graph has a scope selector; Harvest writes to the @@ -35,12 +34,12 @@ import { useOnboarding } from '@/hooks/useOnboarding'; */ export type MindScope = 'personal' | 'workspace'; -export type MemoryView = 'trust' | 'memories' | 'timeline' | 'graph' | 'harvest' | 'weaver' | 'wiki' | 'evolution'; +export type MemoryView = 'trust' | 'memories' | 'timeline' | 'graph' | 'harvest' | 'weaver' | 'wiki'; // PR3.5: 'trust' (screen 19) is the new PRIMARY front door — first + default; // the legacy views demote to secondary (after the divider). export const MEMORY_VIEWS: readonly MemoryView[] = [ - 'trust', 'memories', 'timeline', 'graph', 'harvest', 'weaver', 'wiki', 'evolution', + 'trust', 'memories', 'timeline', 'graph', 'harvest', 'weaver', 'wiki', ]; interface MemoryTabDef { @@ -50,9 +49,9 @@ interface MemoryTabDef { tooltip: string; } -// UX gold-standard H1: 8 equal-weight tabs regrouped into 4 primary + an +// UX gold-standard H1: 7 equal-weight tabs regrouped into 4 primary + an // "Advanced" flyout (display-level IA only — every view id, route and -// ?tab= deep-link is unchanged; MEMORY_VIEWS still validates all 8). +// ?tab= deep-link is unchanged; MEMORY_VIEWS still validates all 7). const PRIMARY_TABS: MemoryTabDef[] = [ { id: 'trust', label: 'Trust', icon: ShieldCheck, tooltip: 'Memory Trust — confidence & freshness, forget / correct / confirm, and "why did you do that?"' }, { id: 'memories', label: 'Memories', icon: Brain, tooltip: 'Memory Center — inspect, edit, review, merge' }, @@ -64,7 +63,6 @@ const ADVANCED_TABS: MemoryTabDef[] = [ { id: 'harvest', label: 'Imports', icon: Download, tooltip: 'Import conversations from other AIs' }, { id: 'weaver', label: 'Maintenance', icon: Activity, tooltip: 'Memory distillation and consolidation' }, { id: 'wiki', label: 'Wiki', icon: BookOpen, tooltip: 'Compiled knowledge pages' }, - { id: 'evolution', label: 'Improvements', icon: Sparkles, tooltip: 'Self-evolving prompts and agents' }, ]; export interface MemoryCenterAppProps { @@ -151,7 +149,7 @@ const MemoryCenterApp = ({