Merge licensing: shipped notices, Apache-2.0 core files and LGPL terms

Every installer and the server archive carry LICENSE and the
third-party notices, and Settings > General links to both. The files
copied from hive-mind-core keep Apache-2.0 with SPDX headers. The LGPL
components name their versions and where their source is. ADR-0010
settles the marketplace catalog question. Logs UF-069 and marks UF-059
Fixed.
This commit is contained in:
shumeiko.it
2026-11-04 19:25:44 +01:00
61 changed files with 1807 additions and 136 deletions

View File

@@ -45,7 +45,8 @@ Implemented in P1.7 with `whatsapp-web.js` 1.34.7 (Puppeteer 24).
`@puppeteer/browsers`, `chromium-bidi`, `webdriver-bidi-protocol`), BSD (`devtools-protocol`,
`extract-zip`), MIT and ISC for the rest, and LGPL-3.0-or-later for `node-webpmux`, a
required dependency of whatsapp-web.js that it loads on startup for sticker metadata. It
ships as a separate, unmodified package. The licensing review has to accept it.
ships as a separate, unmodified package; `THIRD_PARTY_NOTICES.md` carries its LGPL notice,
the license texts and its source location (settled on 2026-11-04, no owner review needed).
- The client is unofficial. Settings warns that WhatsApp may block the account and
recommends a secondary number.
- Risk: whatsapp-web.js awaits page work inside browser event listeners (for example

View File

@@ -94,12 +94,16 @@ copied these tables and the legacy memories (`importLegacyMindData`, `legacy-mem
the owner removed both because the product is still in development and nobody has data to
bring over. A data directory left by the commercial edition is ignored.
The logger, injection scanner, external-memory ingress guard, `WorkspaceManager` and the
embedders were copied from `@waggle/hive-mind-core` into `@waggle/core`, which exports its own
copies. Since P1.5 `@waggle/core` no longer depends on or re-exports the substrate; the
substrate keeps its copies until it is removed in P2.2. Those files came from an
Apache-2.0 package into the MIT `core` package; both are Egzakta's code, and the licence of the
copies is part of the licensing review.
The logger, injection scanner, external-memory ingress guard, `WorkspaceManager`, the
embedders, the recall helpers and execution traces were copied from `@waggle/hive-mind-core`
into `@waggle/core`, which exports its own copies; the awareness and identity layers and parts
of `WaggleDB` were adapted from it. Since P1.5 `@waggle/core` no longer depends on or
re-exports the substrate, which left the repository in P2.2. Those files came from an
Apache-2.0 package into the MIT `core` package and keep Apache-2.0 (settled on 2026-11-04,
no owner decision needed): each carries an `SPDX-License-Identifier: Apache-2.0` header with
the original copyright line, [`packages/core/LICENSE.md`](../../../packages/core/LICENSE.md)
lists them, `packages/core/package.json` declares `MIT AND Apache-2.0`, and
`THIRD_PARTY_NOTICES.md` names them with the Apache-2.0 text.
## The server on mem0 (P1.5, days 7 and 8)

View File

@@ -29,5 +29,9 @@ The catalog stays in the repository for v1. The project owner's representative c
- The Marketplace works on first start without a network.
- Each catalog refresh adds about 14 MB to the history; refreshes stay rare. The public release is
one commit (P2.6), so it starts with a single copy.
- The catalog carries names, descriptions and links of third-party packages. It is added to the
licensing review (Q6).
- The catalog carries package metadata of third-party packages: names, authors, declared
licenses, short descriptions (66 characters on average, at most 391), version numbers, links
and install instructions, as any package index does. It holds none of the packages' code or
content; installing a package fetches it from its source. The project owner left the
licensing question to us, and we settled it on 2026-11-04: the catalog needs no licensing
review and no change.

View File

@@ -25,8 +25,18 @@ work packages wait for the answer.
| Topic | Temporary choice | Blocks |
|---|---|---|
| Licensing review (includes code copied from the Apache-2.0 `hive-mind-core` into MIT `core`, ADR-0007, and the third-party descriptions in the marketplace catalog, ADR-0010) | Technical license checks continue | P2.3, P2.6 |
| Copyright holder in the root `LICENSE` | `Marko Markovic / Egzakta Group`, as in the commercial repository | P2.6 |
| Product name and system identifiers | Temporary names | P1.3d, P2.6 |
| Location of the public repository | `release.yml` is ready but has not run; the installer has no default download location (`--from`) | P2.6, P2.7 |
| Installer signing | First release may ship unsigned with launch instructions | P2.5 |
| PostHog project for the community edition | See ADR-0006 | P1.3a |
The project owner left the other licensing items to us; we settled them on 2026-11-04:
- The files copied from the Apache-2.0 `hive-mind-core` into MIT `core` keep Apache-2.0 and
are marked as such (ADR-0007, [`packages/core/LICENSE.md`](../../../packages/core/LICENSE.md)).
- `LICENSE` and `THIRD_PARTY_NOTICES.md` ship with every installer and the server archive and
open from Settings > General; the notices meet the LGPL terms for libvips and node-webpmux
([UF-059](../upstream-fixes.md)).
- The marketplace catalog holds package metadata (names, short descriptions, links), as any
package index does, and needs no review (ADR-0010).

View File

@@ -87,7 +87,7 @@ Baseline: commit `b20b138` of the main Waggle repository.
| UF-056 | Home calls the last 24 hours "While you slept" | Fixed | Web UI |
| UF-057 | At phone width the sidebar rail takes a fifth of the screen | Fixed | Web UI |
| UF-058 | The mock-embedding warning names a variable Waggle does not read | Fixed | Sidecar, embeddings |
| UF-059 | Installers ship third-party code without its notices | Open | Licensing, packaging |
| UF-059 | Installers ship third-party code without its notices | Fixed | Licensing, packaging |
| UF-060 | The sidecar ships `buffers` 0.1.1, which has no license | Fixed | Licensing |
| UF-061 | Key messages send users to "Settings > API Keys", which does not exist | Fixed | Sidecar |
| UF-062 | The connector suggestion looks for `vault.db`, which never exists | Fixed | Sidecar |
@@ -97,6 +97,7 @@ Baseline: commit `b20b138` of the main Waggle repository.
| UF-066 | Installed builds have no capability packs and no starter skills | Fixed | Sidecar bundle, SDK |
| UF-067 | The status bar names a default model that chats cannot use | Fixed | Sidecar, Web UI |
| UF-068 | Marketplace skills and plugins ignore the configured data directory | Open | Marketplace, sidecar |
| UF-069 | The Apache-2.0 LICENSE of `hive-mind-core` is abridged | Fixed | Licensing |
## Entries
@@ -251,7 +252,7 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
- Where: `packages/server/package.json:30` and `packages/launcher/package.json:42` (`@whiskeysockets/baileys` ^7.0.0-rc13); `packages/server/src/local/channels/whatsapp-adapter.ts:118,260`; `scripts/build-sidecar.mjs` (`EXTERNAL` list)
- Symptom: Baileys itself is MIT, but it depends on `libsignal` 6.0.0 (`WhiskeySockets/libsignal-node`), which is GPL-3.0. Baileys is not in the esbuild `EXTERNAL` list, so the sidecar build bundles Baileys together with `libsignal` into `service.js`, which ships inside the desktop installer. This follows from the build configuration; we have not inspected a built installer.
- Cause: the licenses of transitive dependencies are not checked.
- What we did: the OSS edition replaces Baileys with `whatsapp-web.js` (Apache-2.0), per Egzakta decision Q5 (P1.7, ADR-0005). `libsignal` and Baileys are gone from the lockfile, and `whatsapp-web.js` stays outside the esbuild bundle. Its own dependency `node-webpmux` is LGPL-3.0-or-later and ships as a separate package; that is for the license review.
- What we did: the OSS edition replaces Baileys with `whatsapp-web.js` (Apache-2.0), per Egzakta decision Q5 (P1.7, ADR-0005). `libsignal` and Baileys are gone from the lockfile, and `whatsapp-web.js` stays outside the esbuild bundle. Its own dependency `node-webpmux` is LGPL-3.0-or-later and ships as a separate, unmodified package; `THIRD_PARTY_NOTICES.md` carries its LGPL notice, texts and source location (UF-059).
- Recommendation: include this in the license review (Q6). Shipping GPL-3.0 code inside a binary distributed under other terms is a compliance risk that needs a legal opinion. Options: replace Baileys in the main product as well, or move the WhatsApp connector into a separately installed component. Add a license check for transitive dependencies to CI.
### UF-021. Settings visual-regression baseline is ignored by git
@@ -597,13 +598,13 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
- Recommendation: name `EMBEDDING_PROVIDER` in the banner when the factory runs inside Waggle, or let the caller pass the variable name.
### UF-059. Installers ship third-party code without its notices
- Status: Open
- Status: Fixed
- Found: 2026-11-01
- Where: at commit `b20b138`, `app/src-tauri/tauri.conf.json:16` (`bundle.resources`); `scripts/build-sidecar.mjs` (esbuild bundle of `service.js`); the Vite build of `apps/web`; `app/src-tauri/Cargo.toml`
- Symptom: the desktop installers contain no list of the third-party components and no copy of their license texts. `service.js` inlines about 90 npm packages, the web UI bundle inlines about 300, and the Tauri executable links about 330 Rust crates; most of their licenses (MIT, BSD, Apache-2.0) require the notice to travel with the copies. The LGPL-3.0 libvips libraries that sharp loads (`@img/sharp-libvips-*`, the libvips DLLs in `@img/sharp-win32-x64`) carry no license file of their own, so the installers ship them without the LGPL and GPL texts and without a pointer to their source. Only the packages staged whole into `resources/node_modules` keep their own license files.
- Cause: no step of the build collects third-party notices, and transitive licenses were not checked.
- What we did: the OSS edition generates `THIRD_PARTY_NOTICES.md` with `scripts/generate-third-party-notices.mjs` (the sidecar and web UI closures, the Node.js runtime, the Rust crates, the license texts, and a section on the LGPL, MPL and OFL conditions), and CI runs a license gate (`npm run check:licenses`, cargo-deny with `app/src-tauri/deny.toml`). The notices file is not yet copied into the installers.
- Recommendation: generate the notices in the main project too, add the file to `bundle.resources` and link it from the About screen, and keep a CI license check. The licensing review decides how the LGPL source offer is made.
- What we did: the OSS edition generates `THIRD_PARTY_NOTICES.md` with `scripts/generate-third-party-notices.mjs` (the sidecar and web UI closures, the Node.js runtime, the Rust crates, the license texts, and a section on the LGPL, MPL and OFL conditions), and CI runs a license gate (`npm run check:licenses`, cargo-deny with `app/src-tauri/deny.toml`). On 2026-11-04 the fix was completed: `build-sidecar.mjs` copies `LICENSE` and `THIRD_PARTY_NOTICES.md` next to `service.js` (and fails without them), so the `resources/*` glob of `bundle.resources` puts them into every desktop installer and `build-server-archive.mjs` packs them into the server archive; the sidecar serves both read-only (`GET /api/legal/license`, `GET /api/legal/third-party-notices`, from the packaged copies or the repository root), and Settings > General > About opens them. The LGPL section now carries the canonical LGPL-3.0 and GPL-3.0 texts (`scripts/license-texts/`), names each LGPL component and the LGPL libraries inside libvips with their exact versions, states that they ship unmodified as separate libraries, and gives the upstream source release of each version.
- Recommendation: generate the notices in the main project too, add `LICENSE` and the notices file to `bundle.resources`, link them from Settings or an About screen, and keep a CI license check.
### UF-060. The sidecar ships `buffers` 0.1.1, which has no license
- Status: Fixed
@@ -685,3 +686,12 @@ Entries UF-010 to UF-019 come from the UI audit `anti-slop/audit-001-2026-10-14.
- Cause: the installer builds these paths from `os.homedir()` when its module loads. Only `.mcp.json` honors `WAGGLE_DATA_DIR`, and the MCP route also saves the entry in the server's data directory to make up for it.
- What we did: nothing yet. The community edition changed the default directory name only (ADR-0011).
- Recommendation: pass the server's data directory to `MarketplaceInstaller`, or resolve the paths at call time from `WAGGLE_DATA_DIR` like `mcpConfigPath()`.
### UF-069. The Apache-2.0 LICENSE of `hive-mind-core` is abridged
- Status: Fixed
- Found: 2026-11-04
- Where: at commit `b20b138`, `packages/hive-mind-core/LICENSE`; `packages/hive-mind-hooks-*/LICENSE` and `packages/hive-mind-shim-core/LICENSE`
- Symptom: the `hive-mind-core` LICENSE stops in the middle of section 1 (Definitions) with "For brevity, this is the standard Apache 2.0 license body" and a link, followed by the copyright notice. The LICENSE files of the hooks and shim packages hold only the copyright notice and a link. Apache-2.0 section 4(a) asks for a copy of the license with every redistribution, and these files are the only license text in the packages.
- Cause: the license files were shortened by hand.
- What we did: the files copied from `hive-mind-core` into `@waggle/core` keep Apache-2.0 with an SPDX header and the original copyright line, and `packages/core/LICENSE-APACHE` carries the full, unmodified Apache-2.0 text. `packages/core/LICENSE.md` lists the files.
- Recommendation: replace each abridged LICENSE with the full text from https://www.apache.org/licenses/LICENSE-2.0.txt, keeping the copyright line.