test(server): move the remaining server tests onto the memory contract (P1.5)

- Workspace sessions, fleet runs, agent groups, loops, the file indexer,
  external tool runs, chat and the health endpoint are checked against the
  memory store instead of .mind files. Assertions on mind-cache pins and
  releases go with the pins; the drain and cancellation checks stay.
- Delete the sticky-erasure test (harvest import was removed) and the
  session-distillation test (distillation on workspace activation was
  removed).
- The saved-history retry test checks the conversation only: the failed
  user turn is kept in workspace memory by design (#3).
This commit is contained in:
shumeiko.it
2026-10-24 12:50:23 +02:00
parent 74a4e55be0
commit 122b45990e
12 changed files with 274 additions and 785 deletions

View File

@@ -1,32 +1,25 @@
import { describe, it, expect, vi } from 'vitest';
import { WorkspaceSessionManager, type WorkspaceSession } from '../../src/local/workspace-sessions.js';
import type { MindDB } from '@waggle/core';
import { WorkspaceSessionManager } from '../../src/local/workspace-sessions.js';
import type { Orchestrator } from '@waggle/agent';
function createMockMind(): MindDB {
return {
close: vi.fn(),
} as unknown as MindDB;
}
function createMockTools() {
return [{ name: 'mock_tool', description: 'mock', parameters: {}, execute: async () => 'ok' }];
}
function createMockOrchestrator(): Orchestrator {
return {
setWorkspaceMind: vi.fn(),
setWorkspace: vi.fn(),
} as unknown as Orchestrator;
}
describe('WorkspaceSessionManager', () => {
it('creates a session for a workspace', () => {
const manager = new WorkspaceSessionManager(3);
const mind = createMockMind();
const session = manager.create('ws-1', mind, createMockOrchestrator(), createMockTools());
const orchestrator = createMockOrchestrator();
const session = manager.create('ws-1', orchestrator, createMockTools());
expect(session.workspaceId).toBe('ws-1');
expect(session.mind).toBe(mind);
expect(session.orchestrator).toBe(orchestrator);
expect(session.status).toBe('active');
expect(session.personaId).toBeNull();
expect(manager.size).toBe(1);
@@ -34,34 +27,30 @@ describe('WorkspaceSessionManager', () => {
it('returns existing session on getOrCreate', () => {
const manager = new WorkspaceSessionManager(3);
const mind = createMockMind();
const session1 = manager.create('ws-1', mind, createMockOrchestrator(), createMockTools());
const session1 = manager.create('ws-1', createMockOrchestrator(), createMockTools());
const mindFactory = vi.fn(() => createMockMind());
const orchestratorFactory = vi.fn(() => createMockOrchestrator());
const toolsFactory = vi.fn(() => createMockTools());
const session2 = manager.getOrCreate('ws-1', mindFactory, orchestratorFactory, toolsFactory);
const session2 = manager.getOrCreate('ws-1', orchestratorFactory, toolsFactory);
expect(session2).toBe(session1);
// Factories should NOT have been called (existing session returned)
expect(mindFactory).not.toHaveBeenCalled();
expect(orchestratorFactory).not.toHaveBeenCalled();
expect(toolsFactory).not.toHaveBeenCalled();
});
it('limits to maxSessions (default 3)', () => {
const manager = new WorkspaceSessionManager(2);
manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-2', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-1', createMockOrchestrator(), createMockTools());
manager.create('ws-2', createMockOrchestrator(), createMockTools());
expect(() => manager.create('ws-3', createMockMind(), createMockOrchestrator(), createMockTools()))
expect(() => manager.create('ws-3', createMockOrchestrator(), createMockTools()))
.toThrow('Max concurrent sessions reached (2)');
});
it('closes session and releases resources', () => {
it('closes a session and aborts its agent loop', () => {
const manager = new WorkspaceSessionManager(3);
const mind = createMockMind();
manager.create('ws-1', mind, createMockOrchestrator(), createMockTools());
const session = manager.create('ws-1', createMockOrchestrator(), createMockTools());
expect(manager.has('ws-1')).toBe(true);
const closed = manager.close('ws-1');
@@ -69,44 +58,13 @@ describe('WorkspaceSessionManager', () => {
expect(closed).toBe(true);
expect(manager.has('ws-1')).toBe(false);
expect(manager.size).toBe(0);
expect(mind.close).toHaveBeenCalled();
});
it('releases the cache pin instead of closing a borrowed mind', () => {
const manager = new WorkspaceSessionManager(3);
const mind = createMockMind();
const release = vi.fn();
// Session borrows a cache-owned handle: close() must drop the pin, NOT
// close the shared MindDB (closing it would poison other borrows).
manager.create('ws-1', mind, createMockOrchestrator(), createMockTools(), undefined, release);
expect(manager.close('ws-1')).toBe(true);
expect(release).toHaveBeenCalledTimes(1);
expect(mind.close).not.toHaveBeenCalled();
});
it('rolls back the pin when getOrCreate fails after the mindFactory pins', () => {
const manager = new WorkspaceSessionManager(1);
manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
// ws-1 fills the single slot; creating ws-2 hits the max-sessions cap in
// create() AFTER the mindFactory ran, so getOrCreate must release the pin.
const release = vi.fn();
expect(() => manager.getOrCreate(
'ws-2',
() => createMockMind(),
createMockOrchestrator,
createMockTools,
undefined,
release,
)).toThrow('Max concurrent sessions reached (1)');
expect(release).toHaveBeenCalledTimes(1);
expect(session.abortController.signal.aborted).toBe(true);
});
it('closes idle sessions past threshold', () => {
const manager = new WorkspaceSessionManager(3);
const s1 = manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
const s2 = manager.create('ws-2', createMockMind(), createMockOrchestrator(), createMockTools());
const s1 = manager.create('ws-1', createMockOrchestrator(), createMockTools());
const s2 = manager.create('ws-2', createMockOrchestrator(), createMockTools());
// Make ws-1 idle by backdating its activity
s1.lastActivity = Date.now() - 60000; // 60s ago
@@ -121,8 +79,8 @@ describe('WorkspaceSessionManager', () => {
it('each session has independent abortController', () => {
const manager = new WorkspaceSessionManager(3);
const s1 = manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
const s2 = manager.create('ws-2', createMockMind(), createMockOrchestrator(), createMockTools());
const s1 = manager.create('ws-1', createMockOrchestrator(), createMockTools());
const s2 = manager.create('ws-2', createMockOrchestrator(), createMockTools());
expect(s1.abortController).not.toBe(s2.abortController);
@@ -134,8 +92,8 @@ describe('WorkspaceSessionManager', () => {
it('getActive() returns only open sessions', () => {
const manager = new WorkspaceSessionManager(3);
manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-2', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-1', createMockOrchestrator(), createMockTools());
manager.create('ws-2', createMockOrchestrator(), createMockTools());
const active = manager.getActive();
expect(active).toHaveLength(2);
@@ -144,7 +102,7 @@ describe('WorkspaceSessionManager', () => {
it('pause/resume cycle works', () => {
const manager = new WorkspaceSessionManager(3);
const session = manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
const session = manager.create('ws-1', createMockOrchestrator(), createMockTools());
expect(session.status).toBe('active');
@@ -159,21 +117,19 @@ describe('WorkspaceSessionManager', () => {
it('closeAll() cleans up everything', () => {
const manager = new WorkspaceSessionManager(3);
const m1 = createMockMind();
const m2 = createMockMind();
manager.create('ws-1', m1, createMockOrchestrator(), createMockTools());
manager.create('ws-2', m2, createMockOrchestrator(), createMockTools());
const s1 = manager.create('ws-1', createMockOrchestrator(), createMockTools());
const s2 = manager.create('ws-2', createMockOrchestrator(), createMockTools());
manager.closeAll();
expect(manager.size).toBe(0);
expect(m1.close).toHaveBeenCalled();
expect(m2.close).toHaveBeenCalled();
expect(s1.abortController.signal.aborted).toBe(true);
expect(s2.abortController.signal.aborted).toBe(true);
});
it('supports persona assignment', () => {
const manager = new WorkspaceSessionManager(3);
const session = manager.create(
'ws-1', createMockMind(), createMockOrchestrator(), createMockTools(), 'researcher',
'ws-1', createMockOrchestrator(), createMockTools(), 'researcher',
);
expect(session.personaId).toBe('researcher');
@@ -187,13 +143,13 @@ describe('WorkspaceSessionManager', () => {
describe('addTokens (L-17 C3)', () => {
it('initializes new sessions with tokensUsed = 0', () => {
const manager = new WorkspaceSessionManager(3);
const s = manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
const s = manager.create('ws-1', createMockOrchestrator(), createMockTools());
expect(s.tokensUsed).toBe(0);
});
it('accumulates tokens across multiple calls', () => {
const manager = new WorkspaceSessionManager(3);
manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-1', createMockOrchestrator(), createMockTools());
manager.addTokens('ws-1', 120);
manager.addTokens('ws-1', 80);
@@ -204,8 +160,8 @@ describe('WorkspaceSessionManager', () => {
it('tracks tokens per workspace independently', () => {
const manager = new WorkspaceSessionManager(3);
manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-2', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-1', createMockOrchestrator(), createMockTools());
manager.create('ws-2', createMockOrchestrator(), createMockTools());
manager.addTokens('ws-1', 100);
manager.addTokens('ws-2', 200);
@@ -222,7 +178,7 @@ describe('WorkspaceSessionManager', () => {
it('ignores zero, negative, NaN, and Infinity deltas', () => {
const manager = new WorkspaceSessionManager(3);
manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-1', createMockOrchestrator(), createMockTools());
manager.addTokens('ws-1', 0);
manager.addTokens('ws-1', -50);
@@ -235,7 +191,7 @@ describe('WorkspaceSessionManager', () => {
it('persists accumulated tokens across pause/resume', () => {
const manager = new WorkspaceSessionManager(3);
manager.create('ws-1', createMockMind(), createMockOrchestrator(), createMockTools());
manager.create('ws-1', createMockOrchestrator(), createMockTools());
manager.addTokens('ws-1', 300);
manager.pause('ws-1');